[Scummvm-cvs-logs] CVS: scummvm/scumm gfx.cpp,1.66,1.67

Max Horn fingolfin at users.sourceforge.net
Fri Nov 29 06:23:07 CET 2002


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv29578

Modified Files:
	gfx.cpp 
Log Message:
added MonkeyVGA palette fix, and a FIXME comment

Index: gfx.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/gfx.cpp,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -d -r1.66 -r1.67
--- gfx.cpp	28 Nov 2002 03:08:35 -0000	1.66
+++ gfx.cpp	29 Nov 2002 14:22:31 -0000	1.67
@@ -447,7 +447,12 @@
 		b = *ptr++;
 
 		// This comparison might look wierd, but it's what the disassembly (DOTT) says!
-		if ((_features & GF_AFTER_V7) || (i <= 15 || r < 252 || g < 252 || b < 252)) {
+		// FIXME: Fingolfin still thinks it looks weird: the value 252 = 4*63 clearly comes from
+		// the days 6/6/6 palettes were used, OK. But it breaks MonkeyVGA, so I had to add a
+		// check for that. And somebody before me added a check for V7 games, turning this
+		// off there, too... I wonder if it hurts other games, too? What exactly is broken
+		// if we remove this patch?
+		if ((_features & GID_MONKEY_VGA) || (_features & GF_AFTER_V7) || (i <= 15 || r < 252 || g < 252 || b < 252)) {
 			*dest++ = r;
 			*dest++ = g;
 			*dest++ = b;





More information about the Scummvm-git-logs mailing list