[Scummvm-cvs-logs] CVS: scummvm/scumm script_v5.cpp,1.52,1.53

Max Horn fingolfin at users.sourceforge.net
Tue Apr 29 03:28:09 CEST 2003


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv21488

Modified Files:
	script_v5.cpp 
Log Message:
added some thoughts to Erik's (very nice!) patch

Index: script_v5.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/script_v5.cpp,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -d -r1.52 -r1.53
--- script_v5.cpp	29 Apr 2003 09:14:05 -0000	1.52
+++ script_v5.cpp	29 Apr 2003 10:27:47 -0000	1.53
@@ -647,8 +647,15 @@
 			// Indy3's script 118 to the Passport Demo's script 58
 			// my guess is that it's some sort of "init charset",
 			// but why does it need two parameters?
-			getVarOrDirectByte(0x80);
-			getVarOrDirectByte(0x40);
+			int a = getVarOrDirectByte(0x80);
+			int b = getVarOrDirectByte(0x40);
+			warning("o5_cursorCommand: unknown subopcode 14 (init charset?): %d, %d", a, b);
+			// Maybe the following is what to do (or maybe b instead of a); since I have only
+			// seen a = b = 1, this is not clear; still even if this is right, what's b?
+			// loadCharset(a);
+			// Assuming this is correct, we might not actually need it, as our
+			// initCharset automatically calls loadCharset for GF_SMALL_HEADER, if needed.
+			// And finally, are we sure only Indy3 needs this, and not also e.g. Loom?
 		} else {
 			getWordVararg(table);
 			for (i = 0; i < 16; i++)





More information about the Scummvm-git-logs mailing list