[Scummvm-cvs-logs] CVS: scummvm/scumm charset.cpp,2.96,2.97

Max Horn fingolfin at users.sourceforge.net
Fri Aug 13 17:25:13 CEST 2004


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14218

Modified Files:
	charset.cpp 
Log Message:
FIXME comment regarding blitAlso charset rendering mode (which i believe is broken right now)

Index: charset.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/charset.cpp,v
retrieving revision 2.96
retrieving revision 2.97
diff -u -d -r2.96 -r2.97
--- charset.cpp	14 Aug 2004 00:17:49 -0000	2.96
+++ charset.cpp	14 Aug 2004 00:24:12 -0000	2.97
@@ -1113,6 +1113,13 @@
 	}
 
 	if (_blitAlso && vs->hasTwoBuffers) {
+		// FIXME: Revisiting this code, I think the _blitAlso mode is likely broken
+		// right now -- we are copying stuff from "dst" to "back", but "dst" really
+		// only conatains charset data... 
+		// One way to fix this: don't copy etc.; rather simply render the char twice,
+		// once to each of the two buffers. That should hypothetically yield
+		// identical results, though I didn't try it and right now I don't know
+		// any spots where I can test this...
 		int h = height;
 		do {
 			memcpy(back, dst, width);





More information about the Scummvm-git-logs mailing list