[Scummvm-cvs-logs] SF.net SVN: scummvm: [20740] scummvm/trunk/engines/gob

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Fri Feb 17 00:45:03 CET 2006


Revision: 20740
Author:   fingolfin
Date:     2006-02-17 00:44:16 -0800 (Fri, 17 Feb 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm?rev=20740&view=rev

Log Message:
-----------
Removed lots of unneeded #includes from gob.h, and moved GobGameSettings to gob.cpp -> reduced header dependencies -> faster recompile when one of those headers is modified

Modified Paths:
--------------
    scummvm/trunk/engines/gob/gob.cpp
    scummvm/trunk/engines/gob/gob.h
    scummvm/trunk/engines/gob/music.cpp
    scummvm/trunk/engines/gob/sound.h
Modified: scummvm/trunk/engines/gob/gob.cpp
===================================================================
--- scummvm/trunk/engines/gob/gob.cpp	2006-02-17 00:22:53 UTC (rev 20739)
+++ scummvm/trunk/engines/gob/gob.cpp	2006-02-17 08:44:16 UTC (rev 20740)
@@ -21,8 +21,10 @@
  */
 #include "common/stdafx.h"
 
+#include "base/gameDetector.h"
 #include "base/plugins.h"
 #include "backends/fs/fs.h"
+#include "common/config-manager.h"
 #include "common/md5.h"
 
 #include "gob/gob.h"
@@ -51,7 +53,18 @@
 	kMD5FileSizeLimit = 1024 * 1024
 };
 
-static const Gob::GobGameSettings gob_games[] = {
+struct GobGameSettings {
+	const char *gameid;
+	const char *description;
+	uint32 features;
+	const char *md5sum;
+	GameSettings toGameSettings() const {
+		GameSettings dummy = { gameid, description, features };
+		return dummy;
+	}
+};
+
+static const GobGameSettings gob_games[] = {
 	// Supplied by Florian Zeitz on scummvm-devel
 	{"gob1", "Gobliiins (DOS EGA)", Gob::GF_GOB1, "82aea70ef26f41fa963dfae270993e49"},
 	{"gob1", "Gobliiins (DOS EGA)", Gob::GF_GOB1, "1f499458837008058b8ba6ae07057214"},
@@ -128,7 +141,7 @@
 
 DetectedGameList Engine_GOB_detectGames(const FSList &fslist) {
 	DetectedGameList detectedGames;
-	const Gob::GobGameSettings *g;
+	const GobGameSettings *g;
 	FSList::const_iterator file;
 
 	// Iterate over all files in the given directory
@@ -182,7 +195,7 @@
 		error("Engine_GOB_create(): Cannot find intro.stk");
 	}
 
-	const Gob::GobGameSettings *g;
+	const GobGameSettings *g;
 	bool found = false;
 
 	// TODO

Modified: scummvm/trunk/engines/gob/gob.h
===================================================================
--- scummvm/trunk/engines/gob/gob.h	2006-02-17 00:22:53 UTC (rev 20739)
+++ scummvm/trunk/engines/gob/gob.h	2006-02-17 08:44:16 UTC (rev 20740)
@@ -25,16 +25,9 @@
 
 #include "common/stdafx.h"
 #include "common/system.h"
-#include "sound/mixer.h"
-#include "common/config-manager.h"
 
 #include "base/engine.h"
-#include "base/gameDetector.h"
 
-#include "gob/dataio.h"
-#include "gob/video.h"
-#include "common/file.h"
-
 namespace Gob {
 
 class Game;
@@ -74,17 +67,6 @@
 	GF_MAC = 1 << 5
 };
 
-struct GobGameSettings {
-	const char *gameid;
-	const char *description;
-	uint32 features;
-	const char *md5sum;
-	GameSettings toGameSettings() const {
-		GameSettings dummy = { gameid, description, features };
-		return dummy;
-	}
-};
-
 class GobEngine : public Engine {
 	void errorString(const char *buf_input, char *buf_output);
 

Modified: scummvm/trunk/engines/gob/music.cpp
===================================================================
--- scummvm/trunk/engines/gob/music.cpp	2006-02-17 00:22:53 UTC (rev 20739)
+++ scummvm/trunk/engines/gob/music.cpp	2006-02-17 08:44:16 UTC (rev 20740)
@@ -21,6 +21,8 @@
  *
  */
 
+#include "common/file.h"
+
 #include "gob/music.h"
 #include "gob/gob.h"
 #include "gob/game.h"

Modified: scummvm/trunk/engines/gob/sound.h
===================================================================
--- scummvm/trunk/engines/gob/sound.h	2006-02-17 00:22:53 UTC (rev 20739)
+++ scummvm/trunk/engines/gob/sound.h	2006-02-17 08:44:16 UTC (rev 20740)
@@ -24,6 +24,7 @@
 #define GOB_SOUND_H
 
 #include "sound/audiostream.h"
+#include "sound/mixer.h"
 
 namespace Gob {
 







More information about the Scummvm-git-logs mailing list