[Scummvm-cvs-logs] SF.net SVN: scummvm: [21196] scummvm/trunk/engines/kyra/sound_adlib.cpp

eriktorbjorn at users.sourceforge.net eriktorbjorn at users.sourceforge.net
Thu Mar 9 23:57:02 CET 2006


Revision: 21196
Author:   eriktorbjorn
Date:     2006-03-09 23:56:22 -0800 (Thu, 09 Mar 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=21196&view=rev

Log Message:
-----------
Some more/updated comments.

Modified Paths:
--------------
    scummvm/trunk/engines/kyra/sound_adlib.cpp
Modified: scummvm/trunk/engines/kyra/sound_adlib.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sound_adlib.cpp	2006-03-10 06:05:49 UTC (rev 21195)
+++ scummvm/trunk/engines/kyra/sound_adlib.cpp	2006-03-10 07:56:22 UTC (rev 21196)
@@ -739,8 +739,8 @@
 	// The calculation of frequency looks quite different from the original
 	// disassembly at a first glance, but when you consider that the
 	// largest possible value would be 0x0246 + 0xFF + 0x47 (and that's if
-	// baseFreq turns out to be unsigned after all), freq is still a 10-bit
-	// value, just as it should be to fit in the Ax and Bx registers.
+	// baseFreq is unsigned), freq is still a 10-bit value, just as it
+	// should be to fit in the Ax and Bx registers.
 	//
 	// If it were larger than that, it could have overflowed into the
 	// octave bits, and that could possibly have been used in some sound.
@@ -1847,6 +1847,13 @@
 	0x16, 0x15
 };
 
+// This table is used to modify the frequency of the notes, depending on the
+// note value and unk16. In theory, we could very well try to access memory
+// outside this table, but in reality that probably won't happen.
+//
+// This could be some sort of pitch bend, but I have yet to see it used for
+// anything so it's hard to say.
+
 // TODO: format this
 const uint8 AdlibDriver::_unkTables[][32] = {
 	{    0x00,  0x01,  0x02,  0x03,  0x04,  0x05,  0x06,  0x08,


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.





More information about the Scummvm-git-logs mailing list