[Scummvm-cvs-logs] SF.net SVN: scummvm: [24404] scummvm/trunk/sound/mods/protracker.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Sat Oct 21 13:14:46 CEST 2006


Revision: 24404
          http://svn.sourceforge.net/scummvm/?rev=24404&view=rev
Author:   fingolfin
Date:     2006-10-21 04:14:41 -0700 (Sat, 21 Oct 2006)

Log Message:
-----------
Yuck, mark abuse of OSystem::setSoundCallback

Modified Paths:
--------------
    scummvm/trunk/sound/mods/protracker.cpp

Modified: scummvm/trunk/sound/mods/protracker.cpp
===================================================================
--- scummvm/trunk/sound/mods/protracker.cpp	2006-10-21 11:12:46 UTC (rev 24403)
+++ scummvm/trunk/sound/mods/protracker.cpp	2006-10-21 11:14:41 UTC (rev 24404)
@@ -35,6 +35,13 @@
 
 	_buf = new SoundBuffer();
 
+// FIXME BROKEN: You must NOT use OSystem::setSoundCallback(),
+// ever! The only piece of code allowed to use it is the mixer.
+// And soon the call might be removed completely, too.
+// The proper way to do this is to create a AudioStream
+// subclass and hook that with the mixer. See also the
+// code used by other softsynths (sound/softsynth/emumidi.h).
+
 	_system->setSoundCallback(&audioCallback, this);
 }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list