[Scummvm-cvs-logs] SF.net SVN: scummvm: [25361] scummvm/trunk/gui/ThemeModern.cpp

[fingolfin at users.sourceforge.net]

Revision: 25361
          http://scummvm.svn.sourceforge.net/scummvm/?rev=25361&view=rev
Author:   fingolfin
Date:     2007-02-03 13:35:35 -0800 (Sat, 03 Feb 2007)

Log Message:
-----------
 shalt not declare static vars inside member functions' spoke Fingolfin, and see, there was static all over the place (somebody please fix this, pretty please with sugar atop)

Modified Paths:
--------------
    scummvm/trunk/gui/ThemeModern.cpp

Modified: scummvm/trunk/gui/ThemeModern.cpp
===================================================================
--- scummvm/trunk/gui/ThemeModern.cpp	2007-02-03 21:32:18 UTC (rev 25360)
+++ scummvm/trunk/gui/ThemeModern.cpp	2007-02-03 21:35:35 UTC (rev 25361)
@@ -1301,6 +1301,8 @@
 #pragma mark -
 
 void ThemeModern::processExtraValues() {
+	// FIXME: Using a static (function local) variable like this is *EVIL* and
+	// defeats the purpose of OOP. Turn this into a member variable ASAP!
 	static Common::String imageHandlesTable[kImageHandlesMax];
 
 	// load the pixmap filenames from the config file


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.