[Scummvm-cvs-logs] SF.net SVN: scummvm: [25841] scummvm/trunk/engines/sword1/music.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Sun Feb 25 01:04:36 CET 2007


Revision: 25841
          http://scummvm.svn.sourceforge.net/scummvm/?rev=25841&view=rev
Author:   fingolfin
Date:     2007-02-24 16:04:35 -0800 (Sat, 24 Feb 2007)

Log Message:
-----------
Added TODO: Sword1's MusicHandle::play etc. should be rewritten to take advantage of the enhanced compressed audio stream code

Modified Paths:
--------------
    scummvm/trunk/engines/sword1/music.cpp

Modified: scummvm/trunk/engines/sword1/music.cpp
===================================================================
--- scummvm/trunk/engines/sword1/music.cpp	2007-02-25 00:03:47 UTC (rev 25840)
+++ scummvm/trunk/engines/sword1/music.cpp	2007-02-25 00:04:35 UTC (rev 25841)
@@ -130,6 +130,14 @@
 }
 
 bool MusicHandle::play(const char *fileBase, bool loop) {
+/*
+TODO/FIXME: This should be rewritten to make use of the new audio stream factories.
+In particular, it should take advantage of the looping capabilities; and it
+should avoid reading all the data into memory (by not using the old factory functions).
+Essentially, it seems to me as if we could get rid of createAudioSource().
+
+Maybe it could even be change to use AudioStream::openStreamFile.
+*/
 	char fileName[30];
 	stop();
 	_musicMode = MusicNone;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list