[Scummvm-cvs-logs] SF.net SVN: scummvm: [26240] scummvm/trunk/engines/gob/inter_v1.cpp

[fingolfin at users.sourceforge.net]

Revision: 26240
          http://scummvm.svn.sourceforge.net/scummvm/?rev=26240&view=rev
Author:   fingolfin
Date:     2007-03-19 05:52:18 -0700 (Mon, 19 Mar 2007)

Log Message:
-----------
Added FIXME note into the gob code (it tries to write into datafiles, which makes it unportable to devices with read-only gamedata storage)

Modified Paths:
--------------
    scummvm/trunk/engines/gob/inter_v1.cpp

Modified: scummvm/trunk/engines/gob/inter_v1.cpp
===================================================================
--- scummvm/trunk/engines/gob/inter_v1.cpp	2007-03-19 12:47:14 UTC (rev 26239)
+++ scummvm/trunk/engines/gob/inter_v1.cpp	2007-03-19 12:52:18 UTC (rev 26240)
@@ -1007,6 +1007,12 @@
 	int16 dataVar;
 	int16 retSize;
 
+	// FIXME: This code tries to write to a file. But this is not portable
+	// as datafiles might not be writeable. So we should determine when
+	// precisely this function is used, and see if we can either change it
+	// to a no-op, or use the SaveFileManager instead. If we use savefiles,
+	// then corresponding read etc. file calls would have to be adapted, too.
+
 	evalExpr(0);
 	dataVar = _vm->_parse->parseVarIndex();
 	size = _vm->_parse->parseValExpr();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.