[Scummvm-cvs-logs] SF.net SVN: scummvm: [26766] scummvm/trunk/engines/agi/op_cmd.cpp

[thebluegr at users.sourceforge.net]

Revision: 26766
          http://scummvm.svn.sourceforge.net/scummvm/?rev=26766&view=rev
Author:   thebluegr
Date:     2007-05-06 07:57:35 -0700 (Sun, 06 May 2007)

Log Message:
-----------
Changed a workaround made for Space Trek to apply to all AGI fanmade games. The original workaround was inactive for Space Trek in ScummVM, but was activated for some older AGI games, which was not its original purpose. If this causes regressions with other fanmade games, it'd be best to limit it to Space Trek only

Modified Paths:
--------------
    scummvm/trunk/engines/agi/op_cmd.cpp

Modified: scummvm/trunk/engines/agi/op_cmd.cpp
===================================================================
--- scummvm/trunk/engines/agi/op_cmd.cpp	2007-05-06 14:45:20 UTC (rev 26765)
+++ scummvm/trunk/engines/agi/op_cmd.cpp	2007-05-06 14:57:35 UTC (rev 26766)
@@ -670,7 +670,18 @@
 	g_sprites->eraseUpdSprites();
 	vt.flags |= DRAWN;
 
-	if (g_agi->agiGetRelease() <= 0x2440)	/* See bug #546562 */
+	// WORKAROUND: This fixes a bug with AGI Fanmade game Space Trek.
+	// The original workaround checked if AGI version was <= 2.440, which could
+	// cause regressions with some AGI games. The original workaround no longer
+	// works for Space Trek in ScummVM, as all fanmade games are set to use
+	// AGI version 2.917, but it applies to all other games where AGI version is
+	// <= 2.440, which was not the original purpose of this workaround. It is 
+	// assumed that this bug is caused by AGI Studio, so this applies to all 
+	// fanmade games only.
+	// TODO: Investigate this further and check if any other fanmade AGI
+	// games are affected. If yes, then it'd be best to set this for Space
+	// Trek only
+	if (g_agi->getFeatures() & GF_FANMADE)	/* See Sarien bug #546562 */
 		vt.flags |= ANIMATED;
 
 	g_sprites->blitUpdSprites();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.