[Scummvm-cvs-logs] SF.net SVN: scummvm: [29082] scummvm/trunk/engines/lure/res_struct.cpp

Chris Apers chrilith at hotmail.com
Mon Sep 24 20:11:59 CEST 2007


Hi,

Is this struct alignment safe? if not you should use 
READ_LE_UINT16(&...) instead to prevent alignment error.

Chris

dreammaster at users.sourceforge.net wrote:
> Revision: 29082
>           http://scummvm.svn.sourceforge.net/scummvm/?rev=29082&view=rev
> Author:   dreammaster
> Date:     2007-09-23 17:32:24 -0700 (Sun, 23 Sep 2007)
>
> Log Message:
> -----------
> Added missing endian wrappers from Room Exit structure loading
>
> Modified Paths:
> --------------
>     scummvm/trunk/engines/lure/res_struct.cpp
>
> Modified: scummvm/trunk/engines/lure/res_struct.cpp
> ===================================================================
> --- scummvm/trunk/engines/lure/res_struct.cpp	2007-09-24 00:08:18 UTC (rev 29081)
> +++ scummvm/trunk/engines/lure/res_struct.cpp	2007-09-24 00:32:24 UTC (rev 29082)
> @@ -117,11 +117,11 @@
>  //  Room exit class
>  
>  RoomExitData::RoomExitData(RoomExitResource *rec) {
> -	xs = rec->xs; 
> -	ys = rec->ys;
> -	xe = rec->xe;
> -	ye = rec->ye;
> -	sequenceOffset = rec->sequenceOffset;
> +	xs = FROM_LE_16(rec->xs); 
> +	ys = FROM_LE_16(rec->ys);
> +	xe = FROM_LE_16(rec->xe);
> +	ye = FROM_LE_16(rec->ye);
> +	sequenceOffset = FROM_LE_16(rec->sequenceOffset);
>  	roomNumber = rec->newRoom;
>  	x = rec->newRoomX;
>  	y = rec->newRoomY;
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Scummvm-cvs-logs mailing list
> Scummvm-cvs-logs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-cvs-logs
>
>
>   







More information about the Scummvm-git-logs mailing list