[Scummvm-cvs-logs] SF.net SVN: scummvm: [31701] scummvm/trunk/engines/cine

buddha_ at users.sourceforge.net buddha_ at users.sourceforge.net
Thu Apr 24 22:04:53 CEST 2008


Revision: 31701
          http://scummvm.svn.sourceforge.net/scummvm/?rev=31701&view=rev
Author:   buddha_
Date:     2008-04-24 13:04:53 -0700 (Thu, 24 Apr 2008)

Log Message:
-----------
Cleanup & typo.
- Use sizeof(_name) instead of magic number 10 with memset
- 'usually' instead of 'ussually'
- 'delete[]' instead of 'delete []'
- Fixed parameter name discrepancy between loadResource's definition and declaration

Modified Paths:
--------------
    scummvm/trunk/engines/cine/anim.cpp
    scummvm/trunk/engines/cine/anim.h

Modified: scummvm/trunk/engines/cine/anim.cpp
===================================================================
--- scummvm/trunk/engines/cine/anim.cpp	2008-04-24 20:04:32 UTC (rev 31700)
+++ scummvm/trunk/engines/cine/anim.cpp	2008-04-24 20:04:53 UTC (rev 31701)
@@ -192,7 +192,7 @@
 AnimData::AnimData() : _width(0), _height(0), _bpp(0), _var1(0), _data(NULL),
 	_mask(NULL), _fileIdx(-1), _frameIdx(-1), _realWidth(0), _size(0) {
 
-	memset(_name, 0, 10);
+	memset(_name, 0, sizeof(_name));
 }
 
 /*! \brief Copy constructor
@@ -214,7 +214,7 @@
 		memcpy(_mask, src._mask, _size*sizeof(byte));
 	}
 
-	memset(_name, 0, 10);
+	memset(_name, 0, sizeof(_name));
 	strcpy(_name, src._name);
 }
 
@@ -245,7 +245,7 @@
 
 	_fileIdx = tmp._fileIdx;
 	_frameIdx = tmp._frameIdx;
-	memset(_name, 0, 10);
+	memset(_name, 0, sizeof(_name));
 	strcpy(_name, tmp._name);
 	_realWidth = tmp._realWidth;
 	_size = tmp._size;
@@ -287,7 +287,7 @@
 	_mask = NULL;
 	_fileIdx = file;
 	_frameIdx = frame;
-	memset(_name, 0, 10);
+	memset(_name, 0, sizeof(_name));
 	strcpy(_name, n);
 	_realWidth = w;
 
@@ -358,7 +358,7 @@
  */
 void AnimData::clear() {
 	delete[] _data;
-	delete [] _mask;
+	delete[] _mask;
 
 	_width = 0;
 	_height = 0;
@@ -368,7 +368,7 @@
 	_mask = NULL;
 	_fileIdx = -1;
 	_frameIdx = -1;
-	memset(_name, 0, 10);
+	memset(_name, 0, sizeof(_name));
 	_size = 0;
 }
 
@@ -384,7 +384,7 @@
 	fHandle.writeUint32BE(0); // _mask
 	fHandle.writeUint16BE(_fileIdx);
 	fHandle.writeUint16BE(_frameIdx);
-	fHandle.write(_name, 10);
+	fHandle.write(_name, sizeof(_name));
 }
 
 /*! \brief Clear part of animDataTable

Modified: scummvm/trunk/engines/cine/anim.h
===================================================================
--- scummvm/trunk/engines/cine/anim.h	2008-04-24 20:04:32 UTC (rev 31700)
+++ scummvm/trunk/engines/cine/anim.h	2008-04-24 20:04:53 UTC (rev 31701)
@@ -71,7 +71,7 @@
 	int _size; ///< _data/_mask size, internal only
 
 public:
-	uint16 _width; ///< Image width (ussually twice the real size)
+	uint16 _width; ///< Image width (usually twice the real size)
 	uint16 _height; ///< Image height
 	uint16 _bpp; ///< Bit depth/type information
 	uint16 _var1; ///< Something related to width
@@ -99,7 +99,7 @@
 
 void freeAnimDataTable(void);
 void freeAnimDataRange(byte startIdx, byte numIdx);
-void loadResource(const char *animName);
+void loadResource(const char *resourceName);
 void loadAbs(const char *resourceName, uint16 idx);
 void loadResourcesFromSave(Common::InSaveFile &fHandle, bool broken);
 void generateMask(const byte *sprite, byte *mask, uint16 size, byte transparency);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list