[Scummvm-cvs-logs] SF.net SVN: scummvm:[33722] scummvm/trunk/engines/cine/gfx.cpp

[buddha_ at users.sourceforge.net]

Revision: 33722
          http://scummvm.svn.sourceforge.net/scummvm/?rev=33722&view=rev
Author:   buddha_
Date:     2008-08-09 19:57:46 +0000 (Sat, 09 Aug 2008)

Log Message:
-----------
Made type 21 & 22 overlays not be flipped (The oxygen gauge looks actually better when it reaches zero this way although in its fully charged state it still does look a bit off. Disassembly seems to agree with not flipping the overlays so I'm going with this one for now).

Modified Paths:
--------------
    scummvm/trunk/engines/cine/gfx.cpp

Modified: scummvm/trunk/engines/cine/gfx.cpp
===================================================================
--- scummvm/trunk/engines/cine/gfx.cpp	2008-08-09 19:47:05 UTC (rev 33721)
+++ scummvm/trunk/engines/cine/gfx.cpp	2008-08-09 19:57:46 UTC (rev 33722)
@@ -1127,16 +1127,11 @@
 	// A filled rectangle:
 	case 22: {
 		// TODO: Check it this implementation really works correctly (Some things might be wrong, needs testing).
-		// The drawn rectangle doesn't seem to be flipped in the original disassembly
-		// but looking at the oxygen gauge meter during the first arcade sequence it
-		// definitely looks like the drawing should be at least horizontally flipped.
-		// So this may very well be wrong but having tested only the first arcade sequence's
-		// oxygen gauge this implementation's output *looks* good. It may be wrong still...
 		assert(it->objIdx < NUM_MAX_OBJECT);
 		obj = objectTable + it->objIdx;
 		byte color = obj->part & 0x0F;
-		int width = -obj->frame; // Flipped horizontally for now.
-		int height = -obj->costume; // Flipped vertically for now.
+		int width = obj->frame;
+		int height = obj->costume;
 		drawPlainBox(obj->x, obj->y, width, height, color);
 		debug(5, "renderOverlay: type=%d, x=%d, y=%d, width=%d, height=%d, color=%d",
 			it->type, obj->x, obj->y, width, height, color);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.