[Scummvm-cvs-logs] SF.net SVN: scummvm:[46797] scummvm/trunk/engines/sci/sfx/midiparser.cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Thu Dec 31 12:14:13 CET 2009


Revision: 46797
          http://scummvm.svn.sourceforge.net/scummvm/?rev=46797&view=rev
Author:   thebluegr
Date:     2009-12-31 11:14:13 +0000 (Thu, 31 Dec 2009)

Log Message:
-----------
Mention the fact that we derive from SSCI by not caching the loop selector

Modified Paths:
--------------
    scummvm/trunk/engines/sci/sfx/midiparser.cpp

Modified: scummvm/trunk/engines/sci/sfx/midiparser.cpp
===================================================================
--- scummvm/trunk/engines/sci/sfx/midiparser.cpp	2009-12-31 10:49:16 UTC (rev 46796)
+++ scummvm/trunk/engines/sci/sfx/midiparser.cpp	2009-12-31 11:14:13 UTC (rev 46797)
@@ -200,6 +200,13 @@
 			info.ext.data = _position._play_pos;
 			_position._play_pos += info.length;
 			if (info.ext.type == 0x2F) {// end of track reached
+				// We deviate from SSCI here: in SSCI, the loop is cached, whereas it's
+				// read directly from the sound code here (changed in rev. r46792).
+				// Theoretically, this shouldn't matter at all, as the loop should always
+				// be in sync and should never be changed. In SCI01 and later, the loop is
+				// set from the scripts via cmdSetHandleLoop, so again if there is any
+				// problem with this approach, it'll likely be apparent in SCI0 games
+				// (but no problems have been encountered because of this so far)
 				int16 loop = GET_SEL32V(segMan, _pSnd->soundObj, loop);
 				if (loop)
 					loop--;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list