[Scummvm-cvs-logs] SF.net SVN: scummvm:[42011] scummvm/trunk/engines/scumm/player_v2cms.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Wed Jul 1 22:51:48 CEST 2009


Revision: 42011
          http://scummvm.svn.sourceforge.net/scummvm/?rev=42011&view=rev
Author:   fingolfin
Date:     2009-07-01 20:51:47 +0000 (Wed, 01 Jul 2009)

Log Message:
-----------
Flag what looks like a bug in the CMS player code -- somebody should verify and fix this properly

Modified Paths:
--------------
    scummvm/trunk/engines/scumm/player_v2cms.cpp

Modified: scummvm/trunk/engines/scumm/player_v2cms.cpp
===================================================================
--- scummvm/trunk/engines/scumm/player_v2cms.cpp	2009-07-01 20:51:34 UTC (rev 42010)
+++ scummvm/trunk/engines/scumm/player_v2cms.cpp	2009-07-01 20:51:47 UTC (rev 42011)
@@ -1428,6 +1428,10 @@
 			}
 		
 			_tempoSum += _tempo;
+			// FIXME: _tempoSum is declared as char; on some systems char is unsigned.
+			// E.g. on OS X. Hence the following check is always false.
+			// Moral of the story: Use uint8, int8 or any of the other types provided by
+			// ScummVM if you want to ensure signedness and number of available bits.
 			if (_tempoSum < 0) {
 				// this have to be called in the same rate as in the original (I think)
 				processMidiData(1);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list