[Scummvm-cvs-logs] SF.net SVN: scummvm:[40423] scummvm/trunk/engines/sci/engine

[thebluegr at users.sourceforge.net]

Revision: 40423
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40423&view=rev
Author:   thebluegr
Date:     2009-05-10 14:57:27 +0000 (Sun, 10 May 2009)

Log Message:
-----------
Cleanup

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/kstring.cpp
    scummvm/trunk/engines/sci/engine/message.cpp
    scummvm/trunk/engines/sci/engine/message.h

Modified: scummvm/trunk/engines/sci/engine/kstring.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/kstring.cpp	2009-05-10 14:04:56 UTC (rev 40422)
+++ scummvm/trunk/engines/sci/engine/kstring.cpp	2009-05-10 14:57:27 UTC (rev 40423)
@@ -727,11 +727,11 @@
 static MessageState state;
 
 reg_t kMessage(EngineState *s, int funct_nr, int argc, reg_t *argv) {
-	MessageTuple tuple;
-
 	if (!state.isInitialized())
 		message_state_initialize(s->resmgr, &state);
 
+	MessageTuple tuple;
+
 	switch (UKPV(0)) {
 	case 0:
 	case 2:
@@ -750,7 +750,7 @@
 	switch (UKPV(0)) {
 	case 0 :
 	case 1 :
-		if (UKPV(0) == 0 ? state.getSpecific(&tuple) : state.getNext()) {
+		if (UKPV(0) == 0 ? state.getMessage(&tuple) : state.getNext()) {
 			char *buffer = argc == 7 ? kernel_dereference_char_pointer(s, argv[6], state.getLength() + 1) : NULL;
 
 			if (buffer)
@@ -766,7 +766,7 @@
 			return NULL_REG;
 		}
 	case 2:
-		if (state.getSpecific(&tuple))
+		if (state.getMessage(&tuple))
 			return make_reg(0, state.getLength() + 1);
 		else return NULL_REG;
 	}
@@ -785,7 +785,7 @@
 	tuple.cond = 0;
 	tuple.seq = 0;
 
-	if (state.loadRes(module) && state.getSpecific(&tuple)) {
+	if (state.loadRes(module) && state.getMessage(&tuple)) {
 		int len = state.getLength();
 		char *buffer = kernel_dereference_char_pointer(s, argv[3], len + 1);
 

Modified: scummvm/trunk/engines/sci/engine/message.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/message.cpp	2009-05-10 14:04:56 UTC (rev 40422)
+++ scummvm/trunk/engines/sci/engine/message.cpp	2009-05-10 14:57:27 UTC (rev 40423)
@@ -46,7 +46,7 @@
 	}
 }
 
-int MessageState::getSpecific(MessageTuple *t) {
+int MessageState::getMessage(MessageTuple *t) {
 	MessageTuple looking_at;
 	int found = 0;
 
@@ -75,10 +75,7 @@
 }
 
 int MessageState::getTalker() {
-	if (_version == 2101)
-		return -1;
-	else
-		return *(_engineCursor.index_record + 4);
+	return (_version == 2101) ? -1 : *(_engineCursor.index_record + 4);
 }
 
 void MessageState::getText(char *buffer) {
@@ -110,13 +107,9 @@
 		return 0;
 	}
 
-	if (_version == 2101) {
-		_recordCount = READ_LE_UINT16(_currentResource->data + 4);
-		_indexRecords = _currentResource->data + 6;
-	} else {
-		_recordCount = READ_LE_UINT16(_currentResource->data + 8);
-		_indexRecords = _currentResource->data + 10;
-	}
+	int offs = (_version == 2101) ? 0 : 4;
+	_recordCount = READ_LE_UINT16(_currentResource->data + 4 + offs);
+	_indexRecords = _currentResource->data + 6 + offs;
 
 	initIndexRecordCursor();
 	return 1;
@@ -132,14 +125,12 @@
 
 void message_state_initialize(ResourceManager *resmgr, MessageState *state) {
 	Resource *tester = resmgr->findResource(kResourceTypeMessage, 0, 0);
-	int version;
 
-	if (tester == NULL)
-		return;
-
-	version = READ_LE_UINT16(tester->data);
-	state->initialize(resmgr);
-	state->setVersion(version);
+	if (tester) {
+		int version = READ_LE_UINT16(tester->data);
+		state->initialize(resmgr);
+		state->setVersion(version);
+	}
 }
 
 } // End of namespace Sci

Modified: scummvm/trunk/engines/sci/engine/message.h
===================================================================
--- scummvm/trunk/engines/sci/engine/message.h	2009-05-10 14:04:56 UTC (rev 40422)
+++ scummvm/trunk/engines/sci/engine/message.h	2009-05-10 14:57:27 UTC (rev 40423)
@@ -43,15 +43,9 @@
 	byte *resource_beginning;
 };
 
-//typedef int index_record_size_t();
-typedef void parse_index_record_t(IndexRecordCursor *index_record, MessageTuple *t);
-typedef int get_talker_t(IndexRecordCursor *cursor);
-typedef void get_text_t(IndexRecordCursor *cursor);
-typedef int index_record_count_t(byte *header);
-
 class MessageState {
 public:
-	int getSpecific(MessageTuple *t);
+	int getMessage(MessageTuple *t);
 	int getNext();
 	int getTalker();
 	int getLength();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.