[Scummvm-cvs-logs] SF.net SVN: scummvm:[51838] scummvm/trunk/engines/sci/engine/kpathing.cpp

thebluegr at users.sourceforge.net thebluegr at users.sourceforge.net
Sat Aug 7 18:42:10 CEST 2010


Revision: 51838
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51838&view=rev
Author:   thebluegr
Date:     2010-08-07 16:42:10 +0000 (Sat, 07 Aug 2010)

Log Message:
-----------
SCI: Turned a warning into an error

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/kpathing.cpp

Modified: scummvm/trunk/engines/sci/engine/kpathing.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/kpathing.cpp	2010-08-07 16:17:12 UTC (rev 51837)
+++ scummvm/trunk/engines/sci/engine/kpathing.cpp	2010-08-07 16:42:10 UTC (rev 51838)
@@ -265,7 +265,8 @@
 static Common::Point read_point(SegManager *segMan, reg_t list, int offset) {
 	SegmentRef list_r = segMan->dereference(list);
 	if (!list_r.isValid() || list_r.skipByte) {
-		warning("read_point(): Attempt to dereference invalid pointer %04x:%04x", PRINT_REG(list));
+		// If this happens, then the code below will probably go OOB and crash
+		error("read_point(): Attempt to dereference invalid pointer %04x:%04x", PRINT_REG(list));
 	}
 	Common::Point point;
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list