[Scummvm-cvs-logs] SF.net SVN: scummvm:[47330] scummvm/trunk/engines/sci/graphics

[m_kiewitz at users.sourceforge.net]

Revision: 47330
          http://scummvm.svn.sourceforge.net/scummvm/?rev=47330&view=rev
Author:   m_kiewitz
Date:     2010-01-16 19:44:33 +0000 (Sat, 16 Jan 2010)

Log Message:
-----------
SCI: added TODO inside kAnimate for scalesignal bit 1, added comment about scaling into view class

Modified Paths:
--------------
    scummvm/trunk/engines/sci/graphics/animate.cpp
    scummvm/trunk/engines/sci/graphics/view.cpp

Modified: scummvm/trunk/engines/sci/graphics/animate.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/animate.cpp	2010-01-16 19:25:09 UTC (rev 47329)
+++ scummvm/trunk/engines/sci/graphics/animate.cpp	2010-01-16 19:44:33 UTC (rev 47330)
@@ -168,6 +168,12 @@
 				listEntry->scaleX = 128;
 				listEntry->scaleY = 128;
 			}
+			// TODO
+			// On scaleSignal bit 1 sierra sci does some stuff with global var 2, current Port
+			//  and some other stuff and sets scaleX/Y accordingly. It seems this functionality is needed in at
+			//  least sq5 right when starting the game before wilco exists the room. Currently we dont get scaling
+			//  but sierra sci does scaling there. I dont fully understand the code yet, that's why i didnt implement
+			//  anything.
 		} else {
 			listEntry->scaleSignal = 0;
 			listEntry->scaleX = 128;

Modified: scummvm/trunk/engines/sci/graphics/view.cpp
===================================================================
--- scummvm/trunk/engines/sci/graphics/view.cpp	2010-01-16 19:25:09 UTC (rev 47329)
+++ scummvm/trunk/engines/sci/graphics/view.cpp	2010-01-16 19:44:33 UTC (rev 47330)
@@ -526,6 +526,8 @@
 	}
 }
 
+// We don't fully follow sierra sci here, I did the scaling algo myself and it's definitely not pixel-perfect
+//  with the one sierra is using. It shouldn't matter because the scaled cel rect is definitely the same as in sierra sci
 void View::drawScaled(Common::Rect rect, Common::Rect clipRect, Common::Rect clipRectTranslated, int16 loopNo, int16 celNo, byte priority, int16 scaleX, int16 scaleY) {
 	Palette *palette = _embeddedPal ? &_viewPalette : &_palette->_sysPalette;
 	CelInfo *celInfo = getCelInfo(loopNo, celNo);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.