[Scummvm-cvs-logs] SF.net SVN: scummvm:[50610] scummvm/branches/gsoc2010-opengl/backends/ platform

[vgvgf at users.sourceforge.net]

Revision: 50610
          http://scummvm.svn.sourceforge.net/scummvm/?rev=50610&view=rev
Author:   vgvgf
Date:     2010-07-03 00:25:06 +0000 (Sat, 03 Jul 2010)

Log Message:
-----------
Cleanup and documentation.

Modified Paths:
--------------
    scummvm/branches/gsoc2010-opengl/backends/platform/gp2x/gp2x-common.h
    scummvm/branches/gsoc2010-opengl/backends/platform/linuxmoto/linuxmoto-main.cpp
    scummvm/branches/gsoc2010-opengl/backends/platform/samsungtv/samsungtv.cpp
    scummvm/branches/gsoc2010-opengl/backends/platform/sdl/sdl.h
    scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.cpp
    scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.h

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/gp2x/gp2x-common.h
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/gp2x/gp2x-common.h	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/gp2x/gp2x-common.h	2010-07-03 00:25:06 UTC (rev 50610)
@@ -34,9 +34,6 @@
 
 class OSystem_GP2X : public OSystem_POSIX {
 public:
-	OSystem_GP2X() {}
-	virtual ~OSystem_GP2X() {}
-
 	virtual void initBackend();
 	virtual void quit();
 	virtual void addSysArchivesToSearchSet(Common::SearchSet &s, int priority = 0);

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/linuxmoto/linuxmoto-main.cpp
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/linuxmoto/linuxmoto-main.cpp	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/linuxmoto/linuxmoto-main.cpp	2010-07-03 00:25:06 UTC (rev 50610)
@@ -23,9 +23,6 @@
  *
  */
 
-#include "common/scummsys.h"
-#include "common/system.h"
-
 #include "backends/platform/linuxmoto/linuxmoto-sdl.h"
 #include "base/main.h"
 
@@ -35,6 +32,9 @@
 	g_system = new OSystem_LINUXMOTO();
 	assert(g_system);
 
+	// Pre initialize the backend
+	((OSystem_POSIX *)g_system)->init();
+
 	// Invoke the actual ScummVM main entry point:
 	int res = scummvm_main(argc, argv);
 

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/samsungtv/samsungtv.cpp
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/samsungtv/samsungtv.cpp	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/samsungtv/samsungtv.cpp	2010-07-03 00:25:06 UTC (rev 50610)
@@ -38,6 +38,7 @@
 }
 
 void OSystem_SDL_SamsungTV::initBackend() {
+	// Create the events manager
 	if (_eventManager == 0)
 		_eventManager = new SamsungTVSdlEventManager(this);
 

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/sdl/sdl.h
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/sdl/sdl.h	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/sdl/sdl.h	2010-07-03 00:25:06 UTC (rev 50610)
@@ -63,7 +63,7 @@
 	 */
 	virtual SdlMixerManager *getMixerManager();
 
-	// Override functions from ModularBackend
+	// Override functions from ModularBackend and OSystem
 	virtual void initBackend();
 	virtual Common::HardwareKeySet *getHardwareKeySet();
 	virtual void quit();

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.cpp
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.cpp	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.cpp	2010-07-03 00:25:06 UTC (rev 50610)
@@ -71,9 +71,6 @@
 	
 }
 
-OSystem_SDL_Symbian::~OSystem_SDL_Symbian() {
-}
-
 void OSystem_SDL_Symbian::init() {
 	_RFs = &CEikonEnv::Static()->FsSession();
 	_fsFactory = new SymbianFilesystemFactory();

Modified: scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.h
===================================================================
--- scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.h	2010-07-03 00:13:45 UTC (rev 50609)
+++ scummvm/branches/gsoc2010-opengl/backends/platform/symbian/src/SymbianOS.h	2010-07-03 00:25:06 UTC (rev 50610)
@@ -32,39 +32,40 @@
 class OSystem_SDL_Symbian : public OSystem_SDL {
 public:
 	OSystem_SDL_Symbian();
-	~OSystem_SDL_Symbian();
 
-	// Overloaded from OSystem_SDL
-	void init();
-	void initBackend();
-	void quit();
-	void engineInit();
-	void engineDone();
-	bool setGraphicsMode(const char *name);
-	Common::String getDefaultConfigFileName();
-	void setupIcon();
+	// Override from OSystem_SDL
+	virtual void init();
+	virtual void initBackend();
+	virtual void quit();
+	virtual void engineInit();
+	virtual void engineDone();
+	virtual bool setGraphicsMode(const char *name);
+	virtual Common::String getDefaultConfigFileName();
+	virtual void setupIcon();
 
-	// Returns reference to File session
+	/**
+	 * Returns reference to File session
+	 */
 	RFs& FsSession();
 
 	void quitWithErrorMsg(const char *msg);
 
-	// vibration support
+	// Vibration support
 #ifdef USE_VIBRA_SE_PXXX
-	//
-	// Intialize the vibration api used if present and supported
-	//
+	/**
+	 * Intialize the vibration api used if present and supported
+	 */
 	void initializeVibration();
 
-	//
-	// Turn vibration on, repeat no time
-	// @param vibraLength number of repetitions
-	//
+	/**
+	 * Turn vibration on, repeat no time
+	 * @param vibraLength number of repetitions
+	 */
 	void vibrationOn(int vibraLength);
 
-	//
-	// Turns the vibration off
-	//
+	/**
+	 * Turns the vibration off
+	 */
 	void vibrationOff();
 
 protected:
@@ -72,7 +73,9 @@
 #endif // USE_VIBRA_SE_PXXX
 
 protected:
-	// Used to intialized special game mappings
+	/**
+	 * Used to intialized special game mappings
+	 */
 	void checkMappings();
 
 	RFs* _RFs;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.