[Scummvm-cvs-logs] SF.net SVN: scummvm:[51326] scummvm/trunk/engines/sci/engine/workarounds. cpp

[Max Horn]

Am 26.07.2010 um 19:55 schrieb m_kiewitz at users.sourceforge.net:

> Revision: 51326
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=51326&view=rev
> Author:   m_kiewitz
> Date:     2010-07-26 17:55:54 +0000 (Mon, 26 Jul 2010)
> 
> Log Message:
> -----------
> SCI: extending rats workaround kq6 to all rooms
> 
> fixes bug #3034597
> 

Hi there,

I would recommend to add those bug ids in the comments after each workaround (ideally also retroactively for existing workarounds, but at least for all from now on). This way, it becomes easy to obtain more information about a given workaround than can be put into a single line comment. Experience with workarounds in other engines tells that this can become very handy in the future.

Bye,
Max

> Modified Paths:
> --------------
>    scummvm/trunk/engines/sci/engine/workarounds.cpp
> 
> Modified: scummvm/trunk/engines/sci/engine/workarounds.cpp
> ===================================================================
> --- scummvm/trunk/engines/sci/engine/workarounds.cpp	2010-07-26 17:51:50 UTC (rev 51325)
> +++ scummvm/trunk/engines/sci/engine/workarounds.cpp	2010-07-26 17:55:54 UTC (rev 51326)
> @@ -74,7 +74,7 @@
>     { GID_JONES,         764,   255,  0,                   "", "export 0",       -1,   14, { WORKAROUND_FAKE,   0 } }, // jones/ega&vga only - called when the game starts
>     { GID_KQ5,            -1,     0,  0,                   "", "export 29",      -1,    3, { WORKAROUND_FAKE,   0 } }, // called when playing harp for the harpies or when aborting dialog in toy shop, is used for kDoAudio
>     { GID_KQ5,            25,    25,  0,              "rm025", "doit",           -1,    0, { WORKAROUND_FAKE,   0 } }, // inside witch forest, when going to the room where the walking rock is
> -    { GID_KQ6,            30,    30,  0,               "rats", "changeState",    -1,    0, { WORKAROUND_FAKE,   0 } }, // rats in the catacombs
> +    { GID_KQ6,            -1,    30,  0,               "rats", "changeState",    -1,    0, { WORKAROUND_FAKE,   0 } }, // rats in the catacombs
>     { GID_KQ6,           210,   210,  0,              "rm210", "scriptCheck",    -1,    0, { WORKAROUND_FAKE,   1 } }, // using inventory in that room
>     { GID_KQ6,           500,   500,  0,              "rm500", "init",           -1,    0, { WORKAROUND_FAKE,   0 } }, // going to island of the beast
>     { GID_KQ6,           520,   520,  0,              "rm520", "init",           -1,    0, { WORKAROUND_FAKE,   0 } }, // going to boiling water trap on beast isle
> 
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> ------------------------------------------------------------------------------
> The Palm PDK Hot Apps Program offers developers who use the
> Plug-In Development Kit to bring their C/C++ apps to Palm for a share 
> of $1 Million in cash or HP Products. Visit us here for more details:
> http://ad.doubleclick.net/clk;226879339;13503038;l?
> http://clk.atdmt.com/CRS/go/247765532/direct/01/
> _______________________________________________
> Scummvm-cvs-logs mailing list
> Scummvm-cvs-logs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-cvs-logs
>