[Scummvm-cvs-logs] SF.net SVN: scummvm:[51434] tools/trunk/engines/scumm/compress_scumm_sou. cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Wed Jul 28 23:40:47 CEST 2010


Revision: 51434
          http://scummvm.svn.sourceforge.net/scummvm/?rev=51434&view=rev
Author:   fingolfin
Date:     2010-07-28 21:40:47 +0000 (Wed, 28 Jul 2010)

Log Message:
-----------
TOOLS: cleanup / add FIXME

Modified Paths:
--------------
    tools/trunk/engines/scumm/compress_scumm_sou.cpp

Modified: tools/trunk/engines/scumm/compress_scumm_sou.cpp
===================================================================
--- tools/trunk/engines/scumm/compress_scumm_sou.cpp	2010-07-28 21:33:57 UTC (rev 51433)
+++ tools/trunk/engines/scumm/compress_scumm_sou.cpp	2010-07-28 21:40:47 UTC (rev 51434)
@@ -93,7 +93,7 @@
 		/* Scan for the VCTL header */
 		_input.read_throwsOnError(buf, 4);
 		/* The demo (snmdemo) and floppy version of Sam & Max use VTTL */
-		while (memcmp(buf, "VCTL", 4)&&memcmp(buf, "VTTL", 4)) {
+		while (memcmp(buf, "VCTL", 4) && memcmp(buf, "VTTL", 4)) {
 			pos++;
 			append_byte(4, buf);
 		}
@@ -109,6 +109,9 @@
 	_output_idx.writeUint32BE((uint32)pos);
 	_output_idx.writeUint32BE((uint32)_output_snd.pos());
 	_output_idx.writeUint32BE(tags);
+	// FIXME/TODO: Copying "tags" bytes one by one is
+	// inefficient; should use a buffer (say, "buf") to copy
+	// larger amounts at a time.
 	while (tags > 0) {
 		_output_snd.writeChar(_input.readChar());
 		tags--;
@@ -175,7 +178,7 @@
 	}
 
 	while (get_part())
-		(void)0;// Do nothing
+		;	// Do nothing
 	end_of_file();
 }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list