[Scummvm-cvs-logs] SF.net SVN: scummvm:[48397] scummvm/trunk/engines/m4/mads_views.cpp

lordhoto at users.sourceforge.net lordhoto at users.sourceforge.net
Wed Mar 24 22:39:26 CET 2010


Revision: 48397
          http://scummvm.svn.sourceforge.net/scummvm/?rev=48397&view=rev
Author:   lordhoto
Date:     2010-03-24 21:39:26 +0000 (Wed, 24 Mar 2010)

Log Message:
-----------
Prevent inifinite loop caused by a check of an unsigned integer against >= 0.

Modified Paths:
--------------
    scummvm/trunk/engines/m4/mads_views.cpp

Modified: scummvm/trunk/engines/m4/mads_views.cpp
===================================================================
--- scummvm/trunk/engines/m4/mads_views.cpp	2010-03-24 21:39:02 UTC (rev 48396)
+++ scummvm/trunk/engines/m4/mads_views.cpp	2010-03-24 21:39:26 UTC (rev 48397)
@@ -132,9 +132,12 @@
 }
 
 int ScreenObjects::scanBackwards(int xp, int yp, int layer) {
-	for (uint i = _entries.size() - 1; i >= 0; --i) {
+	for (uint i = _entries.size() - 1; ; --i) {
 		if (_entries[i].active && _entries[i].bounds.contains(xp, yp) && (_entries[i].layer == layer))
 			return i + 1;
+
+		if (i == 0)
+			break;
 	}
 
 	// Entry not found


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list