[Scummvm-cvs-logs] SF.net SVN: scummvm:[54109] scummvm/trunk/engines/mohawk/console.cpp
mthreepwood at users.sourceforge.net
mthreepwood at users.sourceforge.net
Sun Nov 7 03:08:03 CET 2010
Revision: 54109
http://scummvm.svn.sourceforge.net/scummvm/?rev=54109&view=rev
Author: mthreepwood
Date: 2010-11-07 02:08:02 +0000 (Sun, 07 Nov 2010)
Log Message:
-----------
MOHAWK: Remove console FIXME's
Modified Paths:
--------------
scummvm/trunk/engines/mohawk/console.cpp
Modified: scummvm/trunk/engines/mohawk/console.cpp
===================================================================
--- scummvm/trunk/engines/mohawk/console.cpp 2010-11-07 01:03:58 UTC (rev 54108)
+++ scummvm/trunk/engines/mohawk/console.cpp 2010-11-07 02:08:02 UTC (rev 54109)
@@ -545,10 +545,12 @@
// Get CARD/HSPT data and dump their scripts
if (!scumm_stricmp(argv[2], "CARD")) {
- // FIXME: It's weird to use debugN here and not DebugPrintf. But
- // then again, dumpScript() uses debugN, and it is non-trivial
- // to modify that to use DebugPrintf. Hence for now we gotta
- // make do...
+ // Use debugN to print these because the scripts can get very large and would
+ // really be useless if the the text console is not used. A DumpFile could also
+ // theoretically be used, but I (clone2727) typically use this dynamically and
+ // don't want countless files laying around without game context. If one would
+ // want a file of a script they could just redirect stdout to a file or use
+ // deriven.
debugN("\n\nDumping scripts for %s\'s card %d!\n", argv[1], (uint16)atoi(argv[3]));
debugN("==================================\n\n");
Common::SeekableReadStream *cardStream = _vm->getRawData(MKID_BE('CARD'), (uint16)atoi(argv[3]));
@@ -560,7 +562,7 @@
}
delete cardStream;
} else if (!scumm_stricmp(argv[2], "HSPT")) {
- // FIXME: It's weird to use debugN here and not DebugPrintf. See above!
+ // See above for why this is printed via debugN
debugN("\n\nDumping scripts for %s\'s card %d hotspots!\n", argv[1], (uint16)atoi(argv[3]));
debugN("===========================================\n\n");
@@ -583,7 +585,7 @@
DebugPrintf("%s doesn't have any scripts!\n", argv[2]);
}
- // FIXME: It's weird to use debugN here and not DebugPrintf. See above!
+ // See above for why this is printed via debugN
debugN("\n\n");
_vm->changeToStack(oldStack);
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list