[Scummvm-cvs-logs] scummvm master -> d855092f968c555cea4984e937d8badbbde9a50e

[bluegr]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
d855092f96 SCI: Clarified comment in rev 5654e12


Commit: d855092f968c555cea4984e937d8badbbde9a50e
    https://github.com/scummvm/scummvm/commit/d855092f968c555cea4984e937d8badbbde9a50e
Author: md5 (md5 at scummvm.org)
Date: 2011-04-28T00:21:26-07:00

Commit Message:
SCI: Clarified comment in rev 5654e12

It's a bad idea to write comments when half asleep :P

Changed paths:
    engines/sci/sound/soundcmd.cpp



diff --git a/engines/sci/sound/soundcmd.cpp b/engines/sci/sound/soundcmd.cpp
index c6a7fec..1be16f1 100644
--- a/engines/sci/sound/soundcmd.cpp
+++ b/engines/sci/sound/soundcmd.cpp
@@ -345,8 +345,9 @@ reg_t SoundCommandParser::kDoSoundFade(int argc, reg_t *argv, reg_t acc) {
 			musicSlot->fadeStep = volume > musicSlot->fadeTo ? -5 : 5;
 		musicSlot->fadeTickerStep = argv[2].toUint16() * 16667 / _music->soundGetTempo();
 		musicSlot->fadeTicker = 0;
-		// TODO: We only handle zero and non-zero parameters, but this parameter
-		// can have other values as well (e.g. it's 3 in KQ6).
+		// TODO: We handle this as a bit field (i.e. containing values 0 and 1),
+		// but some games pass other values here as well (e.g. some KQ6 scripts
+		// pass 3 here)
 		musicSlot->stopAfterFading = (argc == 5) ? (argv[4].toUint16() != 0) : false;
 
 		// WORKAROUND/HACK: In the labyrinth in KQ6, when falling in the pit and