[Scummvm-cvs-logs] SF.net SVN: scummvm:[55402] scummvm/trunk/engines/toon/toon.cpp

tdhs at users.sourceforge.net tdhs at users.sourceforge.net
Sat Jan 22 02:07:14 CET 2011


Revision: 55402
          http://scummvm.svn.sourceforge.net/scummvm/?rev=55402&view=rev
Author:   tdhs
Date:     2011-01-22 01:07:14 +0000 (Sat, 22 Jan 2011)

Log Message:
-----------
TOON: Fix Uninitialized Memory Read During Cursor Animation on Load.

This was mainly due to _mouseX, which along with the associated variables was not defined until the first mouse event. This was detected by Valgrind.

Modified Paths:
--------------
    scummvm/trunk/engines/toon/toon.cpp

Modified: scummvm/trunk/engines/toon/toon.cpp
===================================================================
--- scummvm/trunk/engines/toon/toon.cpp	2011-01-22 00:00:30 UTC (rev 55401)
+++ scummvm/trunk/engines/toon/toon.cpp	2011-01-22 01:07:14 UTC (rev 55402)
@@ -786,6 +786,11 @@
 	_script_func = NULL;
 	_script = NULL;
 
+	_mouseX = 0;
+	_mouseY = 0;
+	_mouseButton = 0;
+	_lastMouseButton = 0;
+
 	_saveBufferStream = NULL;
 
 	_pathFinding = NULL;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list