[Scummvm-cvs-logs] scummvm master -> f80b2383e7a112106688d79897e7a77fc84f763b

athrxx athrxx at scummvm.org
Mon Jul 4 20:25:51 CEST 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f80b2383e7 KYRA: cleanup last commit


Commit: f80b2383e7a112106688d79897e7a77fc84f763b
    https://github.com/scummvm/scummvm/commit/f80b2383e7a112106688d79897e7a77fc84f763b
Author: athrxx (athrxx at scummvm.org)
Date: 2011-07-04T11:22:16-07:00

Commit Message:
KYRA: cleanup last commit

Changed paths:
    engines/kyra/gui_lok.cpp
    engines/kyra/gui_lol.cpp
    engines/kyra/gui_v2.cpp
    engines/kyra/kyra_mr.cpp
    engines/kyra/kyra_mr.h
    engines/kyra/kyra_v1.cpp
    engines/kyra/sound.cpp
    engines/kyra/sound.h
    engines/kyra/sound_midi.cpp



diff --git a/engines/kyra/gui_lok.cpp b/engines/kyra/gui_lok.cpp
index 4153edc..eba2f8f 100644
--- a/engines/kyra/gui_lok.cpp
+++ b/engines/kyra/gui_lok.cpp
@@ -579,8 +579,8 @@ void GUI_LoK::setupSavegames(Menu &menu, int num) {
 			// Trim long GMM save descriptions to fit our save slots
 			_screen->_charWidth = -2;
 			int fC = _screen->getTextWidth(_savegameNames[i]);
-			while (strlen(_savegameNames[i]) && (fC > 240 || strlen(_savegameNames[i]) >= ARRAYSIZE(_savegameNames[0]))) {
-				_savegameNames[i][strlen(_savegameNames[i]) - 1]  = 0;
+			while (_savegameNames[i][0] && (fC > 240 )) {
+				_savegameNames[i][strlen(_savegameNames[i]) - 1] = 0;
 				fC = _screen->getTextWidth(_savegameNames[i]);
 			}
 			_screen->_charWidth = 0;
diff --git a/engines/kyra/gui_lol.cpp b/engines/kyra/gui_lol.cpp
index 531079b..c64d3e7 100644
--- a/engines/kyra/gui_lol.cpp
+++ b/engines/kyra/gui_lol.cpp
@@ -2580,7 +2580,7 @@ void GUI_LoL::setupSaveMenuSlots(Menu &menu, int num) {
 
 			// Trim long GMM save descriptions to fit our save slots
 			int fC = _screen->getTextWidth(s);
-			while (strlen(s) && fC >= saveSlotMaxLen) {
+			while (s[0] && fC >= saveSlotMaxLen) {
 				s[strlen(s) - 1]  = 0;
 				fC = _screen->getTextWidth(s);
 			}
diff --git a/engines/kyra/gui_v2.cpp b/engines/kyra/gui_v2.cpp
index f086ef3..dcc53b7 100644
--- a/engines/kyra/gui_v2.cpp
+++ b/engines/kyra/gui_v2.cpp
@@ -460,7 +460,7 @@ void GUI_v2::setupSavegameNames(Menu &menu, int num) {
 			// Trim long GMM save descriptions to fit our save slots
 			_screen->_charWidth = -2;
 			int fC = _screen->getTextWidth(s);
-			while (strlen(s) && fC > 240) {
+			while (s[0] && fC > 240) {
 				s[strlen(s) - 1]  = 0;
 				fC = _screen->getTextWidth(s);
 			}
diff --git a/engines/kyra/kyra_mr.cpp b/engines/kyra/kyra_mr.cpp
index c6a5d60..f5bcd04 100644
--- a/engines/kyra/kyra_mr.cpp
+++ b/engines/kyra/kyra_mr.cpp
@@ -1195,11 +1195,6 @@ void KyraEngine_MR::updateMouse() {
 	}
 }
 
-void KyraEngine_MR::pauseEngineIntern(bool pause) {
-	_mixer->pauseAll(pause);
-	_timer->pause(pause);
-}
-
 #pragma mark -
 
 void KyraEngine_MR::makeCharFacingMouse() {
diff --git a/engines/kyra/kyra_mr.h b/engines/kyra/kyra_mr.h
index e03ae08..b762648 100644
--- a/engines/kyra/kyra_mr.h
+++ b/engines/kyra/kyra_mr.h
@@ -105,8 +105,6 @@ private:
 	void updateWithText();
 	void updateMouse();
 
-	void pauseEngineIntern(bool pause);
-
 	// sound specific
 private:
 	void playMenuAudioFile();
diff --git a/engines/kyra/kyra_v1.cpp b/engines/kyra/kyra_v1.cpp
index 3d81368..3b2c9b6 100644
--- a/engines/kyra/kyra_v1.cpp
+++ b/engines/kyra/kyra_v1.cpp
@@ -83,7 +83,9 @@ KyraEngine_v1::KyraEngine_v1(OSystem *system, const GameFlags &flags)
 }
 
 void KyraEngine_v1::pauseEngineIntern(bool pause) {
-	_sound->pause(pause);
+	Engine::pauseEngineIntern(pause);
+	if (_sound)
+		_sound->pause(pause);	
 	_timer->pause(pause);
 }
 
diff --git a/engines/kyra/sound.cpp b/engines/kyra/sound.cpp
index 3713537..4da35cc 100644
--- a/engines/kyra/sound.cpp
+++ b/engines/kyra/sound.cpp
@@ -43,10 +43,6 @@ Sound::Sound(KyraEngine_v1 *vm, Audio::Mixer *mixer)
 Sound::~Sound() {
 }
 
-void Sound::pause(bool paused) {
-	_mixer->pauseAll(paused);
-}
-
 bool Sound::voiceFileIsPresent(const char *file) {
 	for (int i = 0; _supportedCodecs[i].fileext; ++i) {
 		Common::String f = file;
diff --git a/engines/kyra/sound.h b/engines/kyra/sound.h
index 566b37f..c3c3233 100644
--- a/engines/kyra/sound.h
+++ b/engines/kyra/sound.h
@@ -156,7 +156,7 @@ public:
 	/**
 	* Stops all audio playback when paused. Continues after end of pause.
 	*/
-	virtual void pause(bool paused);
+	virtual void pause(bool paused) {}
 
 	void enableMusic(int enable) { _musicEnabled = enable; }
 	int musicEnabled() const { return _musicEnabled; }
diff --git a/engines/kyra/sound_midi.cpp b/engines/kyra/sound_midi.cpp
index dc0f8c1..26b6b31 100644
--- a/engines/kyra/sound_midi.cpp
+++ b/engines/kyra/sound_midi.cpp
@@ -716,9 +716,6 @@ void SoundMidiPC::beginFadeOut() {
 }
 
 void SoundMidiPC::pause(bool paused) {
-	// Stop all mixer related sounds
-	Sound::pause(paused);
-
 	Common::StackLock lock(_mutex);
 
 	if (paused) {






More information about the Scummvm-git-logs mailing list