[Scummvm-cvs-logs] scummvm master -> 2d87394be97e7ed989fabfd0cfbbace204bd213d

[wjp]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2d87394be9 POSIX: Add TODO/FIXME to displayLogFile


Commit: 2d87394be97e7ed989fabfd0cfbbace204bd213d
    https://github.com/scummvm/scummvm/commit/2d87394be97e7ed989fabfd0cfbbace204bd213d
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2011-06-04T07:39:39-07:00

Commit Message:
POSIX: Add TODO/FIXME to displayLogFile

Changed paths:
    backends/platform/sdl/posix/posix.cpp



diff --git a/backends/platform/sdl/posix/posix.cpp b/backends/platform/sdl/posix/posix.cpp
index a45949d..d757186 100644
--- a/backends/platform/sdl/posix/posix.cpp
+++ b/backends/platform/sdl/posix/posix.cpp
@@ -167,6 +167,10 @@ bool OSystem_POSIX::displayLogFile() {
 		execlp("xdg-open", "xdg-open", _logFilePath.c_str(), (char*)0);
 
 		// If we're here, that clearly failed.
+
+		// TODO: We may also want to try detecting the case where
+		// xdg-open is successfully executed but returns an error code.
+
 		// Try xterm+less next
 
 		execlp("xterm", "xterm", "-e", "less", _logFilePath.c_str(), (char*)0);
@@ -182,6 +186,9 @@ bool OSystem_POSIX::displayLogFile() {
 	int status;
 	// Wait for viewer to close.
 	// (But note that xdg-open may have spawned a viewer in the background.)
+
+	// FIXME: We probably want the viewer to always open in the background.
+	// This may require installing a SIGCHLD handler.
 	pid = waitpid(pid, &status, 0);
 
 	if (pid < 0) {