[Scummvm-cvs-logs] scummvm master -> 1ad4feaf05e8630f2a29819ec4cbaeb70ec7e795
lskovlun
lskovlun at sprogklog.dk
Sat Mar 5 21:46:34 CET 2011
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
1ad4feaf05 SCI: Further clarify comment
Commit: 1ad4feaf05e8630f2a29819ec4cbaeb70ec7e795
https://github.com/scummvm/scummvm/commit/1ad4feaf05e8630f2a29819ec4cbaeb70ec7e795
Author: Lars Skovlund (lskovlun at sprogklog.dk)
Date: 2011-03-05T12:46:03-08:00
Commit Message:
SCI: Further clarify comment
Changed paths:
engines/sci/engine/vm_types.cpp
diff --git a/engines/sci/engine/vm_types.cpp b/engines/sci/engine/vm_types.cpp
index 17b08a5..0b790bb 100644
--- a/engines/sci/engine/vm_types.cpp
+++ b/engines/sci/engine/vm_types.cpp
@@ -193,11 +193,13 @@ int reg_t::cmp(const reg_t right, bool treatAsUnsigned) const {
bool reg_t::pointerComparisonWithInteger(const reg_t right) const {
// This function handles the case where a script tries to compare a pointer
// to a number. Normally, we would not want to allow that. However, SCI0 -
- // SCI1 scripts do this in order to distinguish pointers (to resources)
- // from plain numbers. In our SCI implementation, such a check may seem
- // pointless, as one can simply use the segment value to achieve this goal.
- // But Sierra's SCI did not have the notion of segment IDs, so both pointer
- // and numbers were simple integers.
+ // SCI1 scripts do this in order to distinguish references to
+ // external resources (which are numbers) from pointers. In
+ // our SCI implementation, such a check may seem pointless, as
+ // one can simply use the segment value to achieve this goal.
+ // But Sierra's SCI did not have the notion of segment IDs, so
+ // both pointer and numbers were simple integers.
+ //
// But for some things, scripts had (and have) to distinguish between
// numbers and pointers. Lacking the segment information, Sierra's
// developers resorted to a hack: If an integer is smaller than a certain
More information about the Scummvm-git-logs
mailing list