[Scummvm-cvs-logs] scummvm master -> f17b9bc5cb80ce9db75c1c35edf2109c9476ccfa

wjp wjp at usecode.org
Thu Nov 17 10:30:30 CET 2011


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f17b9bc5cb COMMON: Remove outdated fixme


Commit: f17b9bc5cb80ce9db75c1c35edf2109c9476ccfa
    https://github.com/scummvm/scummvm/commit/f17b9bc5cb80ce9db75c1c35edf2109c9476ccfa
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2011-11-17T01:29:11-08:00

Commit Message:
COMMON: Remove outdated fixme

Changed paths:
    backends/timer/default/default-timer.cpp



diff --git a/backends/timer/default/default-timer.cpp b/backends/timer/default/default-timer.cpp
index e1aadb6..8681102 100644
--- a/backends/timer/default/default-timer.cpp
+++ b/backends/timer/default/default-timer.cpp
@@ -122,7 +122,7 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v
 
 	for (i = _callbacks.begin(); i != _callbacks.end(); ++i) {
 		if (i->_value == callback) {
-			error("Same callback is referred by different names (%s vs %s)", i->_key.c_str(), id.c_str());
+			error("Same callback added twice (old name: %s, new name: %s)", i->_key.c_str(), id.c_str());
 		}
 	}
 	_callbacks[id] = callback;
@@ -136,12 +136,6 @@ bool DefaultTimerManager::installTimerProc(TimerProc callback, int32 interval, v
 	slot->nextFireTimeMicro = interval % 1000;
 	slot->next = 0;
 
-	// FIXME: It seems we do allow the client to add one callback multiple times over here,
-	// but "removeTimerProc" will remove *all* added instances. We should either prevent
-	// multiple additions of a timer proc OR we should change removeTimerProc to only remove
-	// a specific timer proc entry.
-	// Probably we can safely just allow a single addition of a specific function once
-	// and just update our Timer documentation accordingly.
 	insertPrioQueue(_head, slot);
 
 	return true;






More information about the Scummvm-git-logs mailing list