[Scummvm-cvs-logs] scummvm master -> ca3ea849d808b7f184cb05c42c317ed19edb73fc

bluegr md5 at scummvm.org
Sat Jun 9 15:31:11 CEST 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ca3ea849d8 SCI: Update information on kGetSierraProfileInt


Commit: ca3ea849d808b7f184cb05c42c317ed19edb73fc
    https://github.com/scummvm/scummvm/commit/ca3ea849d808b7f184cb05c42c317ed19edb73fc
Author: Filippos Karapetis (md5 at scummvm.org)
Date: 2012-06-09T06:29:14-07:00

Commit Message:
SCI: Update information on kGetSierraProfileInt

Thanks to LePhilousophe for his feedback and observations on this

Changed paths:
    engines/sci/engine/kmisc.cpp



diff --git a/engines/sci/engine/kmisc.cpp b/engines/sci/engine/kmisc.cpp
index 9a113bc..f243cf2 100644
--- a/engines/sci/engine/kmisc.cpp
+++ b/engines/sci/engine/kmisc.cpp
@@ -391,6 +391,8 @@ reg_t kGetConfig(EngineState *s, int argc, reg_t *argv) {
 	return argv[1];
 }
 
+// Likely modelled after the Windows 3.1 function GetPrivateProfileInt:
+// http://msdn.microsoft.com/en-us/library/windows/desktop/ms724345%28v=vs.85%29.aspx
 reg_t kGetSierraProfileInt(EngineState *s, int argc, reg_t *argv) {
 	Common::String category = s->_segMan->getString(argv[0]);	// always "config"
 	category.toLowercase();
@@ -402,8 +404,7 @@ reg_t kGetSierraProfileInt(EngineState *s, int argc, reg_t *argv) {
 	if (setting != "videospeed")
 		error("GetSierraProfileInt: setting isn't 'videospeed', it's '%s'", setting.c_str());
 
-	// The game scripts pass 425 as the third parameter for some unknown reason,
-	// as after the call they compare the result to 425 anyway...
+	// The third parameter is 425 (the default if the configuration key is missing)
 
 	// We return the same fake value for videospeed as with kGetConfig
 	return make_reg(0, 500);






More information about the Scummvm-git-logs mailing list