[Scummvm-cvs-logs] scummvm master -> ba1307b0ce37dd8f2f3be36da37d1d88de1fb70e

wjp wjp at usecode.org
Fri Oct 5 16:44:26 CEST 2012


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ba1307b0ce SCI: Add kReadNumber fixme


Commit: ba1307b0ce37dd8f2f3be36da37d1d88de1fb70e
    https://github.com/scummvm/scummvm/commit/ba1307b0ce37dd8f2f3be36da37d1d88de1fb70e
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2012-10-05T07:41:02-07:00

Commit Message:
SCI: Add kReadNumber fixme

Thanks to Walter for noticing this.

Changed paths:
    engines/sci/engine/kstring.cpp



diff --git a/engines/sci/engine/kstring.cpp b/engines/sci/engine/kstring.cpp
index c22d7c7..c4db0b8 100644
--- a/engines/sci/engine/kstring.cpp
+++ b/engines/sci/engine/kstring.cpp
@@ -165,6 +165,7 @@ reg_t kReadNumber(EngineState *s, int argc, reg_t *argv) {
 		// do clipping. In SQ4 we get the door code in here and that's even
 		// larger than uint32!
 		if (*source == '-') {
+			// FIXME: Setting result to -1 does _not_ negate the output.
 			result = -1;
 			source++;
 		}






More information about the Scummvm-git-logs mailing list