[Scummvm-cvs-logs] scummvm master -> 4340c103da3c369be6f065da398596761968d648

Strangerke Strangerke at scummvm.org
Tue Apr 16 07:46:31 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4340c103da HOPKINS: Fix broken condition detected by Coverity


Commit: 4340c103da3c369be6f065da398596761968d648
    https://github.com/scummvm/scummvm/commit/4340c103da3c369be6f065da398596761968d648
Author: Strangerke (strangerke at scummvm.org)
Date: 2013-04-15T22:44:53-07:00

Commit Message:
HOPKINS: Fix broken condition detected by Coverity

Changed paths:
    engines/hopkins/computer.cpp



diff --git a/engines/hopkins/computer.cpp b/engines/hopkins/computer.cpp
index f51e1be..467153e 100644
--- a/engines/hopkins/computer.cpp
+++ b/engines/hopkins/computer.cpp
@@ -864,7 +864,7 @@ void ComputerManager::getScoreName() {
 		displayHiscoreLine(ptr, 9 * strPos + 140, 78, 1);
 
 		char curChar = toupper(_vm->_events->waitKeyPress());
-		if ((curChar < '0') && (curChar > 'Z'))
+		if ((curChar < '0') || (curChar > 'Z'))
 			curChar = ' ';
 		if ((curChar > '9') && (curChar < 'A'))
 			curChar = ' ';






More information about the Scummvm-git-logs mailing list