[Scummvm-cvs-logs] scummvm master -> 38fa74d24ab5065acfdbd65ff3432cd33080d1f1

wjp wjp at usecode.org
Thu Apr 25 22:07:52 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
38fa74d24a SCI: Fix (unlikely) memory leak


Commit: 38fa74d24ab5065acfdbd65ff3432cd33080d1f1
    https://github.com/scummvm/scummvm/commit/38fa74d24ab5065acfdbd65ff3432cd33080d1f1
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2013-04-25T11:48:32-07:00

Commit Message:
SCI: Fix (unlikely) memory leak

Changed paths:
    engines/sci/parser/grammar.cpp



diff --git a/engines/sci/parser/grammar.cpp b/engines/sci/parser/grammar.cpp
index 6e02eb7..26e3ec9 100644
--- a/engines/sci/parser/grammar.cpp
+++ b/engines/sci/parser/grammar.cpp
@@ -386,8 +386,10 @@ ParseRuleList *Vocabulary::buildGNF(bool verbose) {
 
 	for (uint i = 1; i < _parserBranches.size(); i++) { // branch rule 0 is treated specially
 		ParseRule *rule = _vbuild_rule(&_parserBranches[i]);
-		if (!rule)
+		if (!rule) {
+			freeRuleList(ntlist);
 			return NULL;
+		}
 		ntlist = _vocab_add_rule(ntlist, rule);
 	}
 






More information about the Scummvm-git-logs mailing list