[Scummvm-cvs-logs] scummvm master -> 85ba7876d96c851596a4a4a415862f31c492bc96

eriktorbjorn eriktorbjorn at telia.com
Tue Aug 20 08:00:28 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
85ba7876d9 MOHAWK: Add missing break in switch, CID 1003750


Commit: 85ba7876d96c851596a4a4a415862f31c492bc96
    https://github.com/scummvm/scummvm/commit/85ba7876d96c851596a4a4a415862f31c492bc96
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2013-08-19T22:59:24-07:00

Commit Message:
MOHAWK: Add missing break in switch, CID 1003750

Clicking on any of the image boxes would fall through to the case
where it checks if you are picking up or putting away the white
page, which just doesn't make any sense. It didn't have any
noticeable impact on the game, because that case only does
something if the hiding place for the white page is open, and
apparently that can only happen while you're at that hiding place.

I have verified that it's still possible to get the white page,
and that it's still possible to raise the sunken ship.

Changed paths:
    engines/mohawk/myst_stacks/myst.cpp



diff --git a/engines/mohawk/myst_stacks/myst.cpp b/engines/mohawk/myst_stacks/myst.cpp
index f17d765..dc5f433 100644
--- a/engines/mohawk/myst_stacks/myst.cpp
+++ b/engines/mohawk/myst_stacks/myst.cpp
@@ -691,6 +691,7 @@ void Myst::toggleVar(uint16 var) {
 			else
 				_state.courtyardImageBoxes |= mask;
 		}
+		break;
 	case 41: // Vault white page
 		if (_globals.ending != 4) {
 			if (_dockVaultState == 1) {






More information about the Scummvm-git-logs mailing list