[Scummvm-cvs-logs] scummvm master -> b60b3bbecd45d17f95d45512023f5e33a6e96e0e
bluegr
bluegr at gmail.com
Wed Jul 3 03:43:29 CEST 2013
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
b60b3bbecd NEVERHOOD: Fix save slot selection
Commit: b60b3bbecd45d17f95d45512023f5e33a6e96e0e
https://github.com/scummvm/scummvm/commit/b60b3bbecd45d17f95d45512023f5e33a6e96e0e
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2013-07-02T18:41:52-07:00
Commit Message:
NEVERHOOD: Fix save slot selection
My initial suggestion to fix the issue was made in 163023a, which broke
the save slot selection logic. The actual save slot selection problem
was fixed in commit 2ca36ab
Changed paths:
engines/neverhood/menumodule.cpp
diff --git a/engines/neverhood/menumodule.cpp b/engines/neverhood/menumodule.cpp
index 8814401..da7abd4 100644
--- a/engines/neverhood/menumodule.cpp
+++ b/engines/neverhood/menumodule.cpp
@@ -766,9 +766,7 @@ void SavegameListBox::onClick() {
mousePos.y -= _y + _rect.y1;
if (mousePos.x >= 0 && mousePos.x <= _rect.x2 - _rect.x1 &&
mousePos.y >= 0 && mousePos.y <= _rect.y2 - _rect.y1) {
- // We add 1 to the char height to ensure that the correct entry is chosen if the
- // user clicks at the bottom the text entry
- int newIndex = _firstVisibleItem + mousePos.y / (_fontSurface->getCharHeight() + 1);
+ int newIndex = _firstVisibleItem + mousePos.y / _fontSurface->getCharHeight();
if (newIndex <= _lastVisibleItem) {
_currIndex = newIndex;
refresh();
More information about the Scummvm-git-logs
mailing list