[Scummvm-cvs-logs] scummvm master -> 06cc30cf6c02fafc7f6eedeba63b7d8e2f48f944

wjp wjp at usecode.org
Fri Jul 19 21:23:47 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
06cc30cf6c SCI: Add FIXME


Commit: 06cc30cf6c02fafc7f6eedeba63b7d8e2f48f944
    https://github.com/scummvm/scummvm/commit/06cc30cf6c02fafc7f6eedeba63b7d8e2f48f944
Author: Willem Jan Palenstijn (wjp at usecode.org)
Date: 2013-07-19T12:22:36-07:00

Commit Message:
SCI: Add FIXME

Changed paths:
    engines/sci/sound/midiparser_sci.cpp



diff --git a/engines/sci/sound/midiparser_sci.cpp b/engines/sci/sound/midiparser_sci.cpp
index 6a78f49..9653d9cc 100644
--- a/engines/sci/sound/midiparser_sci.cpp
+++ b/engines/sci/sound/midiparser_sci.cpp
@@ -491,6 +491,10 @@ void MidiParser_SCI::parseNextEvent(EventInfo &info) {
 				// though, so ignoring these signals in SCI0 games will result
 				// in glitches (e.g. the intro of LB1 Amiga gets stuck - bug
 				// #3297883). Refer to MusicEntry::setSignal() in sound/music.cpp.
+				// FIXME: SSCI doesn't start playing at the very beginning
+				// of the stream, but at a fixed location a few commands later.
+				// That is probably why this signal isn't triggered
+				// immediately there.
 				if (_soundVersion <= SCI_VERSION_0_LATE ||
 					_position._playTick || info.delta) {
 					_signalSet = true;






More information about the Scummvm-git-logs mailing list