[Scummvm-cvs-logs] scummvm master -> 3dfe25504a5e288af9721229b8311483a6cf1fd2

eriktorbjorn eriktorbjorn at telia.com
Sat Jun 8 23:52:27 CEST 2013


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3dfe25504a SAGA: Add "fallthrough" comments to switch. CID 1003742, 1003743


Commit: 3dfe25504a5e288af9721229b8311483a6cf1fd2
    https://github.com/scummvm/scummvm/commit/3dfe25504a5e288af9721229b8311483a6cf1fd2
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2013-06-08T14:51:29-07:00

Commit Message:
SAGA: Add "fallthrough" comments to switch. CID 1003742, 1003743

I'm almost certain these are intentional fallthroughs. It makes
sense to handle the little-endian cases like the big-endian ones,
with the added FLAG_LITTLE_ENDIAN.

Changed paths:
    engines/saga/shorten.cpp



diff --git a/engines/saga/shorten.cpp b/engines/saga/shorten.cpp
index 69c27b6..619ffc2 100644
--- a/engines/saga/shorten.cpp
+++ b/engines/saga/shorten.cpp
@@ -196,11 +196,13 @@ byte *loadShortenFromStream(Common::ReadStream &stream, int &size, int &rate, by
 			break;
 		case kTypeS16LH:
 			flags |= Audio::FLAG_LITTLE_ENDIAN;
+			// fallthrough
 		case kTypeS16HL:
 			flags |= Audio::FLAG_16BITS;
 			break;
 		case kTypeU16LH:
 			flags |= Audio::FLAG_LITTLE_ENDIAN;
+			// fallthrough
 		case kTypeU16HL:
 			flags |= Audio::FLAG_16BITS;
 			flags |= Audio::FLAG_UNSIGNED;






More information about the Scummvm-git-logs mailing list