[Scummvm-cvs-logs] scummvm master -> 37b77168eceea1f156bfca24fcebdfd53a122486

Strangerke Strangerke at scummvm.org
Wed Aug 6 20:59:39 CEST 2014


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
37b77168ec TOON: Remove some dead code


Commit: 37b77168eceea1f156bfca24fcebdfd53a122486
    https://github.com/scummvm/scummvm/commit/37b77168eceea1f156bfca24fcebdfd53a122486
Author: Strangerke (strangerke at scummvm.org)
Date: 2014-08-06T20:57:30+02:00

Commit Message:
TOON: Remove some dead code

Changed paths:
    engines/toon/toon.cpp



diff --git a/engines/toon/toon.cpp b/engines/toon/toon.cpp
index 14e7d10..2f5051c 100644
--- a/engines/toon/toon.cpp
+++ b/engines/toon/toon.cpp
@@ -2037,23 +2037,19 @@ int32 ToonEngine::characterTalk(int32 dialogid, bool blocking) {
 		}
 	}
 
-	int32 myId = 0;
 	char *myLine;
-	if (dialogid < 1000) {
+	if (dialogid < 1000)
 		myLine = _roomTexts->getText(dialogid);
-		myId = dialogid;
-	} else {
+	else
 		myLine = _genericTexts->getText(dialogid - 1000);
-		myId = dialogid - 1000;
-	}
 
 	if (!myLine)
 		return 0;
 
 	bool oldMouseHidden = _gameState->_mouseHidden;
-	if (blocking) {
+	if (blocking)
 		_gameState->_mouseHidden = true;
-	}
+
 
 	// get what is before the string
 	int a = READ_LE_UINT16(myLine - 2);
@@ -2090,10 +2086,8 @@ int32 ToonEngine::characterTalk(int32 dialogid, bool blocking) {
 			while ((waitChar->getAnimFlag() & 0x10) == 0x10 && !_shouldQuit)
 				doFrame();
 		}
-	} else {
-		if (_audioManager->voiceStillPlaying())
-			_audioManager->stopCurrentVoice();
-	}
+	} else if (_audioManager->voiceStillPlaying())
+		_audioManager->stopCurrentVoice();
 
 	for (int32 i = 0; i < numParticipants - 1; i++) {
 		// listener
@@ -2133,10 +2127,10 @@ int32 ToonEngine::characterTalk(int32 dialogid, bool blocking) {
 	getTextPosition(talkerId, &_currentTextLineX, &_currentTextLineY);
 
 	if (dialogid < 1000) {
-		myId = _roomTexts->getId(dialogid);
+		int myId = _roomTexts->getId(dialogid);
 		_audioManager->playVoice(myId, false);
 	} else {
-		myId = _genericTexts->getId(dialogid - 1000);
+		int myId = _genericTexts->getId(dialogid - 1000);
 		_audioManager->playVoice(myId, true);
 	}
 






More information about the Scummvm-git-logs mailing list