[Scummvm-cvs-logs] scummvm master -> bb70ea04e963a99f164a152db0ad2d9830a94d25

lordhoto lordhoto at gmail.com
Thu Aug 7 15:07:11 CEST 2014


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
bb70ea04e9 TEST: Remove odd test in rendermode tests.


Commit: bb70ea04e963a99f164a152db0ad2d9830a94d25
    https://github.com/scummvm/scummvm/commit/bb70ea04e963a99f164a152db0ad2d9830a94d25
Author: Johannes Schickel (lordhoto at scummvm.org)
Date: 2014-08-07T15:04:13+02:00

Commit Message:
TEST: Remove odd test in rendermode tests.

This specific test checked whether the pointer for two static strings have a
different address. Since the specific strings checked had the same "value"
string pooling optimizations will result in them to have the same address and
thus make this test fail. Furthermore, the test seemed completely pointless,
I simply dropped it now.

Changed paths:
    test/common/rendermode.h



diff --git a/test/common/rendermode.h b/test/common/rendermode.h
index e5e277f..b96ae24 100644
--- a/test/common/rendermode.h
+++ b/test/common/rendermode.h
@@ -49,7 +49,6 @@ class RenderModeTestSuite : public CxxTest::TestSuite {
 		 * Notably, the output should not be in mixed case.
 		 */
 		TS_ASSERT_SAME_DATA(Common::getRenderModeCode(Common::parseRenderMode("FMTOWNS")), "fmtowns", 7);
-		TS_ASSERT_DIFFERS(Common::getRenderModeCode(Common::parseRenderMode("FMTOWNS")), "fmtowns");
 		TS_ASSERT_SAME_DATA(Common::getRenderModeCode(Common::parseRenderMode("CGA")), "cga", 3);
 		TS_ASSERT_SAME_DATA(Common::getRenderModeCode(Common::parseRenderMode("vga")), "vga", 3);
 		TS_ASSERT_SAME_DATA(Common::getRenderModeCode(Common::parseRenderMode("Ega")), "ega", 3);






More information about the Scummvm-git-logs mailing list