[Scummvm-cvs-logs] scummvm master -> f2f8bf5685ecd67af9e2ad26b52af78ebe8c98c8

bluegr bluegr at gmail.com
Fri Aug 8 01:52:39 CEST 2014


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f2f8bf5685 SCI: Fix wrong game features heuristic for Hoyle 1/2 - bug #6606


Commit: f2f8bf5685ecd67af9e2ad26b52af78ebe8c98c8
    https://github.com/scummvm/scummvm/commit/f2f8bf5685ecd67af9e2ad26b52af78ebe8c98c8
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2014-08-08T02:51:57+03:00

Commit Message:
SCI: Fix wrong game features heuristic for Hoyle 1/2 - bug #6606

Games with newer graphics functions can call kDrawPic with 4 or 8
parameters. Older games call it with 6 parameters. Fixes the about
dialog in Hoyle 1

Changed paths:
    engines/sci/engine/features.cpp



diff --git a/engines/sci/engine/features.cpp b/engines/sci/engine/features.cpp
index 31e7ca4..be062db 100644
--- a/engines/sci/engine/features.cpp
+++ b/engines/sci/engine/features.cpp
@@ -344,9 +344,9 @@ bool GameFeatures::autoDetectGfxFunctionsType(int methodNum) {
 			if (kFuncNum == 8) {	// kDrawPic	(SCI0 - SCI11)
 				// If kDrawPic is called with 6 parameters from the overlay
 				// selector, the game is using old graphics functions.
-				// Otherwise, if it's called with 8 parameters, it's using new
-				// graphics functions.
-				_gfxFunctionsType = (argc == 8) ? SCI_VERSION_0_LATE : SCI_VERSION_0_EARLY;
+				// Otherwise, if it's called with 8 parameters (e.g. SQ3) or 4 parameters
+				// (e.g. Hoyle 1/2), it's using new graphics functions.
+				_gfxFunctionsType = (argc == 6) ? SCI_VERSION_0_EARLY : SCI_VERSION_0_LATE;
 				return true;
 			}
 		}






More information about the Scummvm-git-logs mailing list