[Scummvm-cvs-logs] scummvm branch-1-8 -> cf3b112c64921c5a3a9daf8a0659de3898781acc

[sev-]

This automated email contains information about 4 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
538b1db132 UPDATES: Specify version for manual Sparkle download
9d6e640552 UPDATES: Fix appcast URL
c8719ce5d3 UPDATES: Implemented method getLastUpdateCheckTimeAndDate()
cf3b112c64 UPDATES: Plug memory leak


Commit: 538b1db132469083da4bf37e2311053f21d80167
    https://github.com/scummvm/scummvm/commit/538b1db132469083da4bf37e2311053f21d80167
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-04-10T10:01:53+02:00

Commit Message:
UPDATES: Specify version for manual Sparkle download

Changed paths:
    dists/macosx/scummvm_appcast.xml



diff --git a/dists/macosx/scummvm_appcast.xml b/dists/macosx/scummvm_appcast.xml
index a4a15a2..ffd691e 100644
--- a/dists/macosx/scummvm_appcast.xml
+++ b/dists/macosx/scummvm_appcast.xml
@@ -24,6 +24,7 @@
 			<sparkle:releaseNotesLink>
 				https://www.scummvm.org/frs/scummvm/1.7.0/ReleaseNotes
 			</sparkle:releaseNotesLink>
+			<sparkle:version>1.7.0</sparkle:version>
 			<pubDate>Tue, 29 Jul 2014 07:58:00 +0000</pubDate>
 			<link>https://www.scummvm.org/frs/scummvm/1.7.0/</link>
 		</item>


Commit: 9d6e6405524b8e333e94434e90d0c228b374a849
    https://github.com/scummvm/scummvm/commit/9d6e6405524b8e333e94434e90d0c228b374a849
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-04-10T10:01:53+02:00

Commit Message:
UPDATES: Fix appcast URL

Changed paths:
    dists/macosx/scummvm_appcast.xml



diff --git a/dists/macosx/scummvm_appcast.xml b/dists/macosx/scummvm_appcast.xml
index ffd691e..3d47c94 100644
--- a/dists/macosx/scummvm_appcast.xml
+++ b/dists/macosx/scummvm_appcast.xml
@@ -2,7 +2,7 @@
 <rss version="2.0" xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle"  xmlns:dc="http://purl.org/dc/elements/1.1/">
 	<channel>
 		<title>ScummVM Changelog</title>
-		<link>https://www.scummvm.org/scummvm_appcast.xml</link>
+		<link>https://www.scummvm.org/appcasts/macosx/release.xml</link>
 		<description>Most recent changes with links to updates.</description>
 		<language>en</language>
 		<item>


Commit: c8719ce5d35ab2daaef456357b8cf1cc89ba87a1
    https://github.com/scummvm/scummvm/commit/c8719ce5d35ab2daaef456357b8cf1cc89ba87a1
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-04-10T10:02:22+02:00

Commit Message:
UPDATES: Implemented method getLastUpdateCheckTimeAndDate()

Currently it uses methods and constants deprecated in 10.10.
10.10+ -specific code will follow

Changed paths:
    backends/updates/macosx/macosx-updates.h
    backends/updates/macosx/macosx-updates.mm
    common/updates.h



diff --git a/backends/updates/macosx/macosx-updates.h b/backends/updates/macosx/macosx-updates.h
index 9f541ad..6fb9af7 100644
--- a/backends/updates/macosx/macosx-updates.h
+++ b/backends/updates/macosx/macosx-updates.h
@@ -41,6 +41,8 @@ public:
 
 	virtual void setUpdateCheckInterval(int interval);
 	virtual int getUpdateCheckInterval();
+
+	virtual bool getLastUpdateCheckTimeAndDate(TimeDate &t);
 };
 
 #endif
diff --git a/backends/updates/macosx/macosx-updates.mm b/backends/updates/macosx/macosx-updates.mm
index fc967f8..273d80a 100644
--- a/backends/updates/macosx/macosx-updates.mm
+++ b/backends/updates/macosx/macosx-updates.mm
@@ -23,6 +23,7 @@
 // Disable symbol overrides so that we can use system headers.
 #define FORBIDDEN_SYMBOL_ALLOW_ALL
 
+#include "common/system.h"
 #include "backends/updates/macosx/macosx-updates.h"
 
 #ifdef USE_SPARKLE
@@ -133,4 +134,20 @@ int MacOSXUpdateManager::getUpdateCheckInterval() {
 	}
 }
 
+bool MacOSXUpdateManager::getLastUpdateCheckTimeAndDate(TimeDate &t) {
+	NSDate *date = [sparkleUpdater lastUpdateCheckDate];
+	NSCalendar *gregorian = [[NSCalendar alloc] initWithCalendarIdentifier:NSGregorianCalendar];
+	NSDateComponents *components = [gregorian components:(NSDayCalendarUnit | NSWeekdayCalendarUnit) fromDate:date];
+
+	t.tm_wday = [components weekday];
+	t.tm_year = [components year];
+	t.tm_mon = [components month];
+	t.tm_mday = [components day];
+	t.tm_hour = [components hour];
+	t.tm_min = [components minute];
+	t.tm_sec = [components second];
+
+	return true;
+}
+
 #endif
diff --git a/common/updates.h b/common/updates.h
index 65eb5ac..3a3049d 100644
--- a/common/updates.h
+++ b/common/updates.h
@@ -95,6 +95,14 @@ public:
 	virtual int getUpdateCheckInterval() { return kUpdateIntervalNotSupported; }
 
 	/**
+	 * Gets last update check time
+	 *
+	 * @param  t    TimeDate struct to fill out
+	 * @return flag indicating success
+	 */
+	virtual bool getLastUpdateCheckTimeAndDate(TimeDate &t) { return false; }
+
+	/**
 	 * Returns list of supported uptate intervals.
 	 * Ending with '-1' which is not acceptable value.
 	 *


Commit: cf3b112c64921c5a3a9daf8a0659de3898781acc
    https://github.com/scummvm/scummvm/commit/cf3b112c64921c5a3a9daf8a0659de3898781acc
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2016-04-10T10:02:33+02:00

Commit Message:
UPDATES: Plug memory leak

Changed paths:
    backends/updates/macosx/macosx-updates.mm



diff --git a/backends/updates/macosx/macosx-updates.mm b/backends/updates/macosx/macosx-updates.mm
index 273d80a..a7888a7 100644
--- a/backends/updates/macosx/macosx-updates.mm
+++ b/backends/updates/macosx/macosx-updates.mm
@@ -147,6 +147,8 @@ bool MacOSXUpdateManager::getLastUpdateCheckTimeAndDate(TimeDate &t) {
 	t.tm_min = [components minute];
 	t.tm_sec = [components second];
 
+	[gregorian release];
+
 	return true;
 }