[Scummvm-cvs-logs] scummvm master -> 0b4a1ec223d4bd4b1a4060083834b3af7fb8fef5

[Strangerke]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
0b4a1ec223 MOHAWK: Add a comment about suspicious dead code in o_changeBackgroundSound


Commit: 0b4a1ec223d4bd4b1a4060083834b3af7fb8fef5
    https://github.com/scummvm/scummvm/commit/0b4a1ec223d4bd4b1a4060083834b3af7fb8fef5
Author: Strangerke (strangerke at scummvm.org)
Date: 2016-01-12T10:56:25+01:00

Commit Message:
MOHAWK: Add a comment about suspicious dead code in o_changeBackgroundSound

Changed paths:
    engines/mohawk/myst_scripts.cpp



diff --git a/engines/mohawk/myst_scripts.cpp b/engines/mohawk/myst_scripts.cpp
index 15d74a2..41e0660 100644
--- a/engines/mohawk/myst_scripts.cpp
+++ b/engines/mohawk/myst_scripts.cpp
@@ -721,6 +721,8 @@ void MystScriptParser::o_changeBackgroundSound(uint16 op, uint16 var, uint16 arg
 				for (uint16 i = 0; i < condCount; i++) {
 					soundList[i] = argv[decodeIdx++];
 					debugC(kDebugScript, "\t\tCondition %d: Action %d", i, soundList[i]);
+					// CHECKME: At this point, soundAction is always kMystSoundActionConditional (-4)
+					// The soundListVolume is therefore always set to 65535
 					if (soundAction == kMystSoundActionChangeVolume || soundAction > 0) {
 						soundListVolume[i] = argv[decodeIdx++];
 					} else