[Scummvm-cvs-logs] scummvm master -> b75f6182b0596e885e4fe70719b818d9cb32694e

dreammaster dreammaster at scummvm.org
Sat Jan 30 05:03:04 CET 2016


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b75f6182b0 SHERLOCK: RT: Simplify ascii char checks, since we don't support accents


Commit: b75f6182b0596e885e4fe70719b818d9cb32694e
    https://github.com/scummvm/scummvm/commit/b75f6182b0596e885e4fe70719b818d9cb32694e
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2016-01-29T23:02:28-05:00

Commit Message:
SHERLOCK: RT: Simplify ascii char checks, since we don't support accents

Changed paths:
    engines/sherlock/tattoo/widget_files.cpp
    engines/sherlock/tattoo/widget_foolscap.cpp
    engines/sherlock/tattoo/widget_password.cpp



diff --git a/engines/sherlock/tattoo/widget_files.cpp b/engines/sherlock/tattoo/widget_files.cpp
index ca5e1bf..ff8cb83 100644
--- a/engines/sherlock/tattoo/widget_files.cpp
+++ b/engines/sherlock/tattoo/widget_files.cpp
@@ -386,7 +386,7 @@ bool WidgetFiles::getFilename() {
 			done = -1;
 		}
 
-		if ((keyState.ascii >= ' ') && ((keyState.ascii <= 168) || (keyState.ascii == 225)) && (index < 50)) {
+		if ((keyState.ascii >= ' ') && (keyState.ascii <= 'z') && (index < 50)) {
 			if (pt.x + _surface.charWidth(keyState.ascii) < _surface.w() - BUTTON_SIZE - 20) {
 				if (insert)
 					filename.insertChar(keyState.ascii, index);
diff --git a/engines/sherlock/tattoo/widget_foolscap.cpp b/engines/sherlock/tattoo/widget_foolscap.cpp
index 8246e9a..c8df71e 100644
--- a/engines/sherlock/tattoo/widget_foolscap.cpp
+++ b/engines/sherlock/tattoo/widget_foolscap.cpp
@@ -184,8 +184,7 @@ void WidgetFoolscap::handleKeyboardEvents() {
 	TattooUserInterface &ui = *(TattooUserInterface *)_vm->_ui;
 	Common::KeyState keyState = ui._keyState;
 
-	if (((toupper(keyState.ascii) >= 'A') && (toupper(keyState.ascii) <= 'Z')) ||
-		((keyState.ascii >= 128) && ((keyState.ascii <= 168) || (keyState.ascii == 225)))) {
+	if ((toupper(keyState.ascii) >= 'A') && (toupper(keyState.ascii) <= 'Z')) {
 		// Visible key pressed, set it and set the keycode to move the caret to the right
 		_answers[_lineNum][_charNum] = keyState.ascii;
 		keyState.keycode = Common::KEYCODE_RIGHT;
diff --git a/engines/sherlock/tattoo/widget_password.cpp b/engines/sherlock/tattoo/widget_password.cpp
index 3dd0e30..57a5e02 100644
--- a/engines/sherlock/tattoo/widget_password.cpp
+++ b/engines/sherlock/tattoo/widget_password.cpp
@@ -159,7 +159,7 @@ void WidgetPassword::handleEvents() {
 	} else if (keycode == Common::KEYCODE_RETURN || keycode == Common::KEYCODE_ESCAPE) {
 		close();
 		return;
-	} else if (((ui._keyState.ascii >= ' ' && ui._keyState.ascii < 169) || ui._keyState.ascii == 225)) {
+	} else if ((ui._keyState.ascii >= ' ') && (ui._keyState.ascii <= 'z')) {
 		if (_cursorPos.x + _surface.charWidth(ui._keyState.ascii) < _bounds.width() - _surface.widestChar() - 3) {
 			if (_insert)
 				_password.insertChar(ui._keyState.ascii, _index);






More information about the Scummvm-git-logs mailing list