[Scummvm-git-logs] scummvm master -> 92c9f0274f28842f5d75a77d8bbeb9c4bd4bbe4a

Tkachov Tkachov at users.noreply.github.com
Wed Feb 15 13:37:50 CET 2017


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
92c9f0274f GUI: Fix CID #1362505


Commit: 92c9f0274f28842f5d75a77d8bbeb9c4bd4bbe4a
    https://github.com/scummvm/scummvm/commit/92c9f0274f28842f5d75a77d8bbeb9c4bd4bbe4a
Author: Alexander (Tkachov at users.noreply.github.com)
Date: 2017-02-15T18:37:46+06:00

Commit Message:
GUI: Fix CID #1362505

The case probably would never show up, just fixed so it'd disappear from Coverity.

Changed paths:
    gui/options.cpp


diff --git a/gui/options.cpp b/gui/options.cpp
index aa5f7b4..8b459b2 100644
--- a/gui/options.cpp
+++ b/gui/options.cpp
@@ -2013,7 +2013,7 @@ void GlobalOptionsDialog::reflowLayout() {
 void GlobalOptionsDialog::setupCloudTab() {
 	int serverLabelPosition = -1; //no override
 #ifdef USE_LIBCURL
-	_selectedStorageIndex = _storagePopUp->getSelectedTag();
+	_selectedStorageIndex = (_storagePopUp ? _storagePopUp->getSelectedTag() : Cloud::kStorageNoneId);
 
 	if (_storagePopUpDesc) _storagePopUpDesc->setVisible(true);
 	if (_storagePopUp) _storagePopUp->setVisible(true);





More information about the Scummvm-git-logs mailing list