[Scummvm-git-logs] scummvm master -> f5a20ab45410b32b51647ec22151d4b0fe632e60

[rsn8887]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f5a20ab454 PSP2: new g++ flags fix crashing scumm-7-8 games


Commit: f5a20ab45410b32b51647ec22151d4b0fe632e60
    https://github.com/scummvm/scummvm/commit/f5a20ab45410b32b51647ec22151d4b0fe632e60
Author: rsn8887 (rsn8887 at users.noreply.github.com)
Date: 2017-03-10T22:25:39-06:00

Commit Message:
PSP2: new g++ flags fix crashing scumm-7-8 games

The Dig and Full Throttle were both crashing on startup on PSP2 (Vita)
when -O2, -O3, or -Os compiler optimizations were enabled. The problem
is fixed by adding the "-fno-optimize-sibling-calls" compiler flag.

Changed paths:
    configure


diff --git a/configure b/configure
index 43b8957..d958c0e 100755
--- a/configure
+++ b/configure
@@ -2663,8 +2663,15 @@ case $_host_os in
 		append_var CXXFLAGS "-Wl,-q -I$VITASDK/arm-vita-eabi/include"
 		append_var CXXFLAGS "-march=armv7-a -mtune=cortex-a9 -mfpu=neon -mfloat-abi=hard"
 		append_var LDFLAGS "-Wl,-q -L$VITASDK/arm-vita-eabi/lib"
+		#the next line fixes a crash when starting scumm-7-8 games (The Dig etc.)
+		#when either -O2, -O3 or -Os optimizations are enabled
+		append_var CXXFLAGS "-fno-optimize-sibling-calls"
+		#the next line fixes "branch out of range" error in gob engine when -Os is used
 		append_var CXXFLAGS "-mlong-calls"
 		if test "$_debug_build" = no; then
+		#optimize for smallest file size. This is necessary to prevent a crash on startup
+		#due to the large executable file size when many engines are enabled
+		#for example when --enable-all-engines is used to enable all the unstable engines
 			_optimization_level=-Os
 		fi
 		if test "$_debug_build" = yes; then