[Scummvm-git-logs] scummvm master -> 3194c308ee58d7d02a59e0367daaba5222d6be2f

dreammaster dreammaster at scummvm.org
Mon Mar 27 00:35:21 CEST 2017


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3194c308ee TITANIC: Minor cleanups, TODO removals


Commit: 3194c308ee58d7d02a59e0367daaba5222d6be2f
    https://github.com/scummvm/scummvm/commit/3194c308ee58d7d02a59e0367daaba5222d6be2f
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2017-03-26T18:35:07-04:00

Commit Message:
TITANIC: Minor cleanups, TODO removals

Changed paths:
    engines/titanic/star_control/star_control_sub13.cpp
    engines/titanic/star_control/star_control_sub5.cpp
    engines/titanic/star_control/surface_area.cpp


diff --git a/engines/titanic/star_control/star_control_sub13.cpp b/engines/titanic/star_control/star_control_sub13.cpp
index 190ae20..1e9cffb 100644
--- a/engines/titanic/star_control/star_control_sub13.cpp
+++ b/engines/titanic/star_control/star_control_sub13.cpp
@@ -63,13 +63,7 @@ CStarControlSub13::CStarControlSub13(CStarControlSub13 *src) :
 }
 
 void CStarControlSub13::copyFrom(const CStarControlSub13 *src) {
-	if (src) {
-		// TODO: Not really certain src is a CStarControlSub13
-		_position = src->_position;
-		_fieldC = src->_field18;
-		_field10 = src->_field1C;
-		error("TODO: Remainder of CStarControlSub13::copyFrom");
-	}
+	error("Unused function");
 }
 
 void CStarControlSub13::load(SimpleFile *file, int param) {
diff --git a/engines/titanic/star_control/star_control_sub5.cpp b/engines/titanic/star_control/star_control_sub5.cpp
index 092e7eb..e4a9739 100644
--- a/engines/titanic/star_control/star_control_sub5.cpp
+++ b/engines/titanic/star_control/star_control_sub5.cpp
@@ -63,8 +63,6 @@ bool CStarControlSub5::setup() {
 }
 
 bool CStarControlSub5::setup2(int val1, int val2) {
-	// TODO: Original set an explicit random seed here. Could be
-	// problematic if following random values need to be deterministic
 	const double FACTOR = 2 * M_PI / 360.0;
 	const int VALUES1[] = { 0x800, 0xC00, 0x1000, 0x1400, 0x1800 };
 	const int VALUES2[] = {
diff --git a/engines/titanic/star_control/surface_area.cpp b/engines/titanic/star_control/surface_area.cpp
index 6faf0ac..a3029bd 100644
--- a/engines/titanic/star_control/surface_area.cpp
+++ b/engines/titanic/star_control/surface_area.cpp
@@ -229,7 +229,7 @@ double CSurfaceArea::fillRect(const FRect &rect) {
 		}
 	}
 
-	// TODO: Lots more functionality
+	// Lots more functionality
 */
 	return r.top;
 }





More information about the Scummvm-git-logs mailing list