[Scummvm-git-logs] scummvm master -> 0fd4e80cb29d7b2f58b303b5ba5f380d5c51c0e4

dreammaster dreammaster at scummvm.org
Wed Oct 11 01:50:43 CEST 2017


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
0fd4e80cb2 TITANIC: Fix buffer overflow in parser searchAndReplace


Commit: 0fd4e80cb29d7b2f58b303b5ba5f380d5c51c0e4
    https://github.com/scummvm/scummvm/commit/0fd4e80cb29d7b2f58b303b5ba5f380d5c51c0e4
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2017-10-10T19:50:35-04:00

Commit Message:
TITANIC: Fix buffer overflow in parser searchAndReplace

Changed paths:
    engines/titanic/true_talk/tt_parser.cpp


diff --git a/engines/titanic/true_talk/tt_parser.cpp b/engines/titanic/true_talk/tt_parser.cpp
index f230179..2331cbe 100644
--- a/engines/titanic/true_talk/tt_parser.cpp
+++ b/engines/titanic/true_talk/tt_parser.cpp
@@ -371,6 +371,7 @@ int TTparser::searchAndReplace(TTstring &line, int startIndex, const StringArray
 				// Replace the text in the line with it's replacement
 				line = CString(line.c_str(), line.c_str() + startIndex) + replacementStr +
 					CString(line.c_str() + startIndex + origStr.size());
+				lineSize = line.size();
 
 				startIndex += replacementStr.size();
 				break;





More information about the Scummvm-git-logs mailing list