[Scummvm-git-logs] scummvm master -> 3676c3886d9c1ee6ac95bdb312ce61a0d1af9061

bonki bonki at users.noreply.github.com
Sat Apr 21 01:00:42 CEST 2018


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3676c3886d TUCKER: Fix panel background being off by one pixel


Commit: 3676c3886d9c1ee6ac95bdb312ce61a0d1af9061
    https://github.com/scummvm/scummvm/commit/3676c3886d9c1ee6ac95bdb312ce61a0d1af9061
Author: Adrian Frühwirth (bonki at users.noreply.github.com)
Date: 2018-04-21T00:57:12+02:00

Commit Message:
TUCKER: Fix panel background being off by one pixel

This fixes an original game glitch where the main options menu background
image is drawn one pixel too high.

Fixes Trac#10496.

Changed paths:
    engines/tucker/tucker.cpp


diff --git a/engines/tucker/tucker.cpp b/engines/tucker/tucker.cpp
index a459c34..3a49260 100644
--- a/engines/tucker/tucker.cpp
+++ b/engines/tucker/tucker.cpp
@@ -1979,7 +1979,12 @@ void TuckerEngine::redrawPanelItems() {
 			sz = 19200;
 			break;
 		case kPanelTypeLoadSavePlayQuit:
-			src = _panelGfxBuf + 16320;
+			// The following offset does not match disassembly on purpose to fix a
+			// "glitch" in the original game.
+			// This ensures that the background image ends up in the same place as
+			// in the case of kPanelTypeLoadSaveSavegame.
+			// This fixes Trac#10496.
+			src = _panelGfxBuf + 16000;
 			dst = _itemsGfxBuf;
 			sz = 19200;
 			memcpy(dst, src, sz);





More information about the Scummvm-git-logs mailing list