[Scummvm-git-logs] scummvm master -> b4c1efe2f22f7daefc748b49ffca4839c457e391

bonki bonki at users.noreply.github.com
Tue Mar 20 22:26:12 CET 2018


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b4c1efe2f2 TUCKER: Remove superfluous workaround for Trac#4156


Commit: b4c1efe2f22f7daefc748b49ffca4839c457e391
    https://github.com/scummvm/scummvm/commit/b4c1efe2f22f7daefc748b49ffca4839c457e391
Author: Adrian Frühwirth (bonki at users.noreply.github.com)
Date: 2018-03-20T22:22:11+01:00

Commit Message:
TUCKER: Remove superfluous workaround for Trac#4156

Despite what the comment says this does not seem to be in the original
game and I cannot replicate this in either the original or a current
ScummVM build. It is highly likely that this was one of several sprite
offset bugs which were present in our implementation earlier but which
have since been fixed.

Changed paths:
    engines/tucker/tucker.cpp


diff --git a/engines/tucker/tucker.cpp b/engines/tucker/tucker.cpp
index f392526..66422d3 100644
--- a/engines/tucker/tucker.cpp
+++ b/engines/tucker/tucker.cpp
@@ -1842,11 +1842,6 @@ void TuckerEngine::drawBackgroundSprites() {
 }
 
 void TuckerEngine::drawCurrentSprite() {
-	// Workaround original game glitch: skip first bud frame drawing when entering location (tracker item #2597763)
-	if ((_locationNum == 17 || _locationNum == 18) && _currentSpriteAnimationFrame == 16) {
-		return;
-	}
-
 	// WORKAROUND: original game glitch
 	// Locations 48 and 61 contain reserved colors from [0xE0-0xF8] in a walkable area which
 	// results in a number of pixels being falsely drawn in the foreground (on top of Bud).





More information about the Scummvm-git-logs mailing list