[ scummvm-Bugs-588501 ] FOA: Bad colours for light and shadows

[noreply at sourceforge.net]

Bugs item #588501, was opened at 2002-07-30 12:55
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=588501&group_id=37116

Category: Graphics
Group: Indiana Jones 4
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: FOA: Bad colours for light and shadows

Initial Comment:
This applies to the July 29 CVS snapshot:

In the scene where you dive for Atlantis, the colours
for the boat and submarine shadows are incorrect (see
attached screen shot). A similar phenomenon also
happens when riding the subway car.

In both these cases, unkRoomFunc3() will be called,
which currently does nothing. My theory is that it
should be setting up the _transEffect[] array. The
first two arguments look like they would be min and max
colours, while the remaining three arguments could be
scale factors for R, G, and B.

I've included a rough patch which produces reasonable
results for the diving scene and the first half of the
subway car ride. That I'm not submitting it as a batch
is because it's pretty broken in some other respects.
The colours look strange in the second half of the
subway ride, and the light doesn't fade out like I
think it should. Also, since the _transEffect[] array
isn't saved, restoring a saved game during one of these
scenes will cause bad colours as well.

I checked with 0.2.0, and for some reason I don't get
the psychedelic colours or recent snapshots. Instead,
the submarine shadow is rendered as solid black.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=588501&group_id=37116